-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New module avm/res/service-networking/traffic-controller
#3169
Merged
AlexanderSehr
merged 22 commits into
Azure:main
from
krbar:users/krbar/trafficControllerModule
Oct 2, 2024
Merged
feat: New module avm/res/service-networking/traffic-controller
#3169
AlexanderSehr
merged 22 commits into
Azure:main
from
krbar:users/krbar/trafficControllerModule
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
labels
Sep 4, 2024
…into users/krbar/trafficControllerModule
…into users/krbar/trafficControllerModule
avm/res/service-networking/traffic-controller/frontend/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/service-networking/traffic-controller/association/main.bicep
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
…into users/krbar/trafficControllerModule
@AlexanderSehr, thanks for the review, your comments are implemented and the tests refreshed. |
eriqua
added
Class: Resource Module 📦
This is a resource module
and removed
Needs: Triage 🔍
Maintainers need to triage still
labels
Oct 1, 2024
AlexanderSehr
approved these changes
Oct 2, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Class: Resource Module 📦
This is a resource module
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Module
avm/res/service-networking/traffic-controller
(Application Gateway for Containers).Related Module Proposal: Azure/Azure-Verified-Modules#712
Adding a new module
brm validate
locally to verify the module files.Pipeline references