Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New module avm/res/service-networking/traffic-controller #3169

Merged
merged 22 commits into from
Oct 2, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Sep 4, 2024

Description

New Module avm/res/service-networking/traffic-controller (Application Gateway for Containers).

Related Module Proposal: Azure/Azure-Verified-Modules#712

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.service-networking.traffic-controller

@krbar krbar self-assigned this Sep 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 4, 2024
@krbar krbar marked this pull request as ready for review September 4, 2024 21:18
@krbar krbar requested review from a team as code owners September 4, 2024 21:18
@krbar krbar added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Sep 4, 2024
krbar and others added 2 commits October 1, 2024 21:34
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
@krbar
Copy link
Contributor Author

krbar commented Oct 1, 2024

@AlexanderSehr, thanks for the review, your comments are implemented and the tests refreshed.

@eriqua eriqua requested a review from AlexanderSehr October 1, 2024 23:44
@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 1, 2024
@AlexanderSehr AlexanderSehr merged commit e549f47 into Azure:main Oct 2, 2024
8 checks passed
@krbar krbar deleted the users/krbar/trafficControllerModule branch October 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants