Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small fix for both the post-removal logic & secret-passthru with PSRule #3149

Merged
merged 9 commits into from
Sep 3, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Fixed the post-deployment loop referencing incorrect variables
  • Enabled PSRule to work with secrets pass-thru parameters it must be able to expand

Pipeline Reference

Pipeline
avm.res.compute.virtual-machine

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 2, 2024
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Sep 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 2, 2024
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Sep 2, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 3, 2024 08:14
@AlexanderSehr AlexanderSehr requested review from a team as code owners September 3, 2024 08:14
@AlexanderSehr AlexanderSehr merged commit 30a2e47 into main Sep 3, 2024
14 of 15 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/ciRemovalAndPSRuleFix branch September 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.managed-services.registration-definition
2 participants