fix: SQL Server ZR default updates #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
|
Hey @tsc-buddy, to your question: What we can do is to merge your PR into a branch in AVM other than main, retest from there and go from there to main. Would that be alright? |
I think that would be a great approach! Lets do it! |
AlexanderSehr
changed the base branch from
main
to
users/alsehr/tsc-buddy_feat/sql-zr-update
AlexanderSehr
merged commit 103161b
into
Azure:users/alsehr/tsc-buddy_feat/sql-zr-update
10 checks passed
11 tasks
AlexanderSehr
added a commit
that referenced
this pull request
Aug 30, 2024
## Description | Pipeline | | -------- | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml) Follow up to #3093: Addresses Zone Redundancy gaps for WAF Alignment by default. Please note the pipeline fails becuase dev/test subscriptions do not support maintenance windows which are configured on WAF and MAX tests. @AlexanderSehr can we run this against the AVM environment and confirm it goes green! ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | |[](https://github.com/tsc-buddy/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml)| ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [x] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> Co-authored-by: Buddy <[email protected]>
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml){kind=link}
|](https://github.com/tsc-buddy/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml/badge.svg)](https://github.com/tsc-buddy/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml)|){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses Zone Redundancy gaps for WAF Alignment by default. Please note the pipeline fails becuase dev/test subscriptions do not support maintenance windows which are configured on WAF and MAX tests. @AlexanderSehr can we run this against the AVM environment and confirm it goes green!
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.