Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional parameters for anf #3055

Merged
merged 39 commits into from
Aug 21, 2024

Conversation

bobmclane999
Copy link
Contributor

@bobmclane999 bobmclane999 commented Aug 16, 2024

Description

Additional parameters for -

  • snapshot policies
  • backup policies
  • backup vaults and backups
  • encryptionKeySource - Microsot.KeyVault or Microsoft.NetApp
  • Latest API's 2024-03-01 as per NetApp releases
  • fix ternary statements

Pipeline Reference

Pipeline
avm.res.net-app.net-app-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 16, 2024
@fbinotto fbinotto self-assigned this Aug 19, 2024
Copy link
Contributor

@fbinotto fbinotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide green deployment badge to confirm this was successfully deployed.

@bobmclane999 bobmclane999 requested a review from fbinotto August 20, 2024 15:38
@bobmclane999
Copy link
Contributor Author

Please provide green deployment badge to confirm this was successfully deployed.

Green badge attached. Will look into Alexander's request to split out the backup and snapshot policies on my return from holiday.

@bobmclane999
Copy link
Contributor Author

Hi @fbinotto @AlexanderSehr @jtracey93 - green badge now attached.
As above if this PR can be approved as is and once back from vacation I'll look to put the backup policies and snapshot policies into their own files... unless someone else has some time to do while I'm OOTO ;P
Thanks for all your help!
Cheers
Shaun

@fbinotto
Copy link
Contributor

fbinotto commented Aug 21, 2024

Approved, @bobmclane999 please split backup policies and snapshot policies into their own files once you are back. @AlexanderSehr @jtracey93 please approve and merge.

fbinotto
fbinotto previously approved these changes Aug 21, 2024
Copy link
Contributor

@fbinotto fbinotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobmclane999
Copy link
Contributor Author

Approved, @bobmclane999 please split backup policies and snapshot policies into their own files once you are back. @AlexanderSehr @jtracey93 please approve and merge.

Thanks for the flexibility guys, much appreciated! Will add a backlog Task in our board to sort once back... tyvm
@jtracey93 / @AlexanderSehr - If you could please approve also that would be awesome then I can get my ANF volumes deployed in Prod :)...
Regards
Shaun

@jtracey93 jtracey93 closed this Aug 21, 2024
@jtracey93 jtracey93 reopened this Aug 21, 2024
@jtracey93 jtracey93 merged commit 9cef9b3 into Azure:main Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants