-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/ptn/ai-platform/baseline
Add VNet, Bastion and VM to module
#2900
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
bc3a827
to
f7b5d62
Compare
Description
This PR adds the second half of Azure/Azure-Verified-Modules#1150, adding the VNet, virtual machine, and Bastion host. The configuration for the VM is based on https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.machinelearningservices/machine-learning-end-to-end-secure/modules/dsvmjumpbox.bicep in the Azure docs.
Note there are a number of failing tests in the pipeline that I'm not sure why they're failing, as I thought I'd fixed them:
Azure.Deployment.AdminUsername
Azure.NSG.LateralTraversal
Azure.VM.AMA
Azure.VNET.UseNSGs
is also failing forAzureBastionSubnet
, however I don't think this is necessary for Bastion (and even if it was added, it would then failAzure.NSG.LateralTraversal
).Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.