Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/ptn/ai-platform/baseline Add VNet, Bastion and VM to module #2900

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

cecheta
Copy link
Member

@cecheta cecheta commented Jul 31, 2024

Description

This PR adds the second half of Azure/Azure-Verified-Modules#1150, adding the VNet, virtual machine, and Bastion host. The configuration for the VM is based on https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.machinelearningservices/machine-learning-end-to-end-secure/modules/dsvmjumpbox.bicep in the Azure docs.

Note there are a number of failing tests in the pipeline that I'm not sure why they're failing, as I thought I'd fixed them:

  • Azure.Deployment.AdminUsername
  • Azure.NSG.LateralTraversal
  • Azure.VM.AMA

Azure.VNET.UseNSGs is also failing for AzureBastionSubnet, however I don't think this is necessary for Bastion (and even if it was added, it would then fail Azure.NSG.LateralTraversal).

Pipeline Reference

Pipeline
avm.ptn.ai-platform.baseline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@cecheta cecheta requested a review from ross-p-smith July 31, 2024 20:12
@cecheta cecheta requested review from a team as code owners July 31, 2024 20:12

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 31, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@matebarabas matebarabas added Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Triage 🔍 Maintainers need to triage still labels Aug 6, 2024
@cecheta cecheta merged commit a72a5c7 into Azure:main Aug 14, 2024
4 checks passed
@cecheta cecheta deleted the ai-platform-vnet branch August 14, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants