Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI - Fixed error test formatting for static validation #2862

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jul 28, 2024

Description

  • Fixed incorrect variable naming for formating failed tests for GH output
  • Aligned naming of different scenarios (passed, failed, warning) to reduce this happening again in the future
  • After retesting, addressed failing static tests

Pipeline Reference

Pipeline
avm.ptn.ai-platform.baseline
avm.res.machine-learning-services.workspace
avm.res.recovery-services.vault

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 28, 2024
@AlexanderSehr AlexanderSehr added the Type: Bug 🐛 Something isn't working label Jul 28, 2024
@AlexanderSehr AlexanderSehr self-assigned this Jul 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jul 28, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review July 28, 2024 08:13
@AlexanderSehr AlexanderSehr requested review from a team as code owners July 28, 2024 08:13
@AlexanderSehr AlexanderSehr added Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Triage 🔍 Maintainers need to triage still labels Jul 28, 2024
@AlexanderSehr AlexanderSehr changed the title fix: Fixed error test formatting for static validation fix: CI - Fixed error test formatting for static validation Jul 28, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 28, 2024 08:13
@AlexanderSehr AlexanderSehr added the Type: CI 🚀 This issue is related to the AVM CI label Jul 28, 2024
@AlexanderSehr AlexanderSehr merged commit ab827a6 into main Jul 30, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/errorTestOutput branch July 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
2 participants