Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/data-factory/factory Added various UDTs #2763

Conversation

donheerschap
Copy link
Contributor

@donheerschap donheerschap commented Jul 22, 2024

Description

Added UDTs for:

  • Managed Private Endpoints
  • Integration Runtimes
  • Linked Services

For a better dev experience.

Pipeline Reference

Pipeline
avm.res.data-factory.factory

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jul 22, 2024
@donheerschap
Copy link
Contributor Author

Can't test the deployments because my MPN ran out of credits.

@clintgrove clintgrove removed the Needs: Triage 🔍 Maintainers need to triage still label Jul 24, 2024
@clintgrove clintgrove self-assigned this Jul 24, 2024
@donheerschap donheerschap marked this pull request as ready for review July 26, 2024 12:02
@donheerschap donheerschap requested review from a team as code owners July 26, 2024 12:02
@donheerschap
Copy link
Contributor Author

@clintgrove Tests are passing, feel free to review 😄

@krbar krbar added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Jul 26, 2024
@AlexanderSehr
Copy link
Contributor

Hey @donheerschap,
I'm currently going through long-running PRs and just found this one. To move the subject forward, I'll merge the PR into an intermediate branch to resolve the conflicts & re-test the changes from our end to subsequently merge it into main. This should help us to get these great additions finally in.

@AlexanderSehr AlexanderSehr changed the base branch from main to users/alsehr/donheerschap/add-adf-udts August 29, 2024 12:14
@AlexanderSehr AlexanderSehr merged commit 38b4a89 into Azure:users/alsehr/donheerschap/add-adf-udts Aug 29, 2024
3 checks passed
AlexanderSehr added a commit that referenced this pull request Oct 1, 2024
## Description

Follow-up to #2763

---
Quote: @donheerschap
Added UDTs for:

Managed Private Endpoints
Integration Runtimes
Linked Services
For a better dev experience.

> Edit: @AlexanderSehr also addressed linter warnings

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.data-factory.factory](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml/badge.svg?branch=users%2Falsehr%2Fdonheerschap%2Fadd-adf-udts&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Don Heerschap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants