-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional parameters for anf #2695
feat: additional parameters for anf #2695
Conversation
Align to AVM Spec and use CDT for CMK
removed test statement
…of netapp accounts
@jtracey93 Please do you mind give this PR the once over ? As only 2nd one :) I presume I can't resolve the conflicts but most are changes to the json/readme files post Set-AVVMModule..? Thanks guys! |
hey @bobmclane999, i think you ned to pull in and merge and resolve those merge conflicts. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line Something like:
|
Take your time @bobmclane999 and @jtracey93 I still have to merge #2636 before I consider this PR. And that PR has some of the changes proposed here. |
Hi @fbinotto yeah we had the issues with the resourceId duplication on the WAF aligned tests similar to #2636 so had to make a similar change to get the test working - Sorry to push :( but do you have a timescale on approving the other PR (well and this one :)) as we are mid project for a File Migration using ANF so deadlines are a little tight hence all the changes... tyvm Shaun |
57b0f6c
to
ce325e3
Compare
It should be merged today or tomorrow, then you should be able to update your PR and I can approve. |
Hey @bobmclane999, I see @fbinotto's PR is now merged thanks to @AlexanderSehr's approval 👍 You can now pull in these changes into your branch and then re-run the test and README generation etc. and then @fbinotto should be good to review and get this one approved and merged too 👍 |
@bobmclane999 please do so before tomorrow night as I will be on leave for a week. |
@fbinotto are you happy for me to approve in your absence if needed? |
Thanks @jtracey93 . @fbinotto - Yeah that would be really appreciated as although I've done this it may need tweaking and I'm supposed to be OOTO today :) Thanks both for all your help with this!! Sorry still a bit of a newb at this. |
@fbinotto looks like its good for a review, lets see if we can get it in before you go, if not let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor change and we can merge,
Yes, go ahead. I have requested only a minor change. |
@fbinotto / @jtracey93 - have put networkFeatures and Zones params back and previous and submitted the PR again for review... thanks muchly Shaun :) |
@bobmclane999 did you re-run the |
Hi @jtracey93 actually no I didn't let me do and let you know when I've re-submitted tyvm |
Hi @jtracey93 - re-ran a test after another commit (post Set-AVMModule) and have another badge here - Is this the correct place to put it ? |
Description
Additional parameters for NetApp -
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.