-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/ptn/ai-platform/baseline
New module
#2694
feat: avm/ptn/ai-platform/baseline
New module
#2694
Conversation
660cb97
to
535e01b
Compare
f3cff46
to
290c8ab
Compare
avm/ptn/ai-platform/baseline
New module
Ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to make it closed by default including the storage account to be not externally accessible by defualt so they should be locked down including no internet access so this would also require you to create a vnet to put those in. The idea it is to use AVM modules instead of direct resources where possible.
The storage account is currently private by default and is created using an AVM module I intend to add a VNet in a subsequent PR, for now AI studio can reach the storage account through its own managed VNet, where private endpoints are created automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Chinedum!
Description
This is v0.1.0 of the new
avm/ptn/ai-platform/baseline
pattern: Azure/Azure-Verified-Modules#1150Upcoming in later versions:
Note that there appears to be a bug when trying to create an AI project via ARM when the managed VNet is enabled, therefore it is not currently created by the pattern.
Managed network cannot be disabled once enabled.
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.