Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/ptn/ai-platform/baseline New module #2694

Merged
merged 14 commits into from
Jul 17, 2024

Conversation

cecheta
Copy link
Member

@cecheta cecheta commented Jul 10, 2024

Description

This is v0.1.0 of the new avm/ptn/ai-platform/baseline pattern: Azure/Azure-Verified-Modules#1150

  • Creates AI hub workspace, with accompanying resources
  • Allows creation of compute resources

Upcoming in later versions:

  • Create VNet
  • Create Azure bastion + VM
  • Create private endpoints from VNet to resources
  • Create connections in AI hub

Note that there appears to be a bug when trying to create an AI project via ARM when the managed VNet is enabled, therefore it is not currently created by the pattern. Managed network cannot be disabled once enabled.

Pipeline Reference

Pipeline
avm.ptn.ai-platform.baseline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@cecheta cecheta requested review from a team as code owners July 10, 2024 13:32
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jul 10, 2024
@cecheta cecheta added Type: Feature Request ➕ New feature or request Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Triage 🔍 Maintainers need to triage still labels Jul 10, 2024
@cecheta cecheta force-pushed the cecheta/ai-platform-pattern branch from 660cb97 to 535e01b Compare July 10, 2024 17:27
@cecheta cecheta force-pushed the cecheta/ai-platform-pattern branch from f3cff46 to 290c8ab Compare July 11, 2024 08:15
@cecheta cecheta changed the title feat: avm/ptn/ai-platform/baseline New module feat: avm/ptn/ai-platform/baseline New module Jul 11, 2024
@cecheta
Copy link
Member Author

cecheta commented Jul 11, 2024

Ready for review again

Copy link
Member

@Nepomuceno Nepomuceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to make it closed by default including the storage account to be not externally accessible by defualt so they should be locked down including no internet access so this would also require you to create a vnet to put those in. The idea it is to use AVM modules instead of direct resources where possible.

@cecheta
Copy link
Member Author

cecheta commented Jul 12, 2024

I think it would be good to make it closed by default including the storage account to be not externally accessible by defualt so they should be locked down including no internet access so this would also require you to create a vnet to put those in. The idea it is to use AVM modules instead of direct resources where possible.

The storage account is currently private by default and is created using an AVM module

I intend to add a VNet in a subsequent PR, for now AI studio can reach the storage account through its own managed VNet, where private endpoints are created automatically

@cecheta cecheta requested review from Nepomuceno and a team and removed request for Nepomuceno July 12, 2024 10:03
Copy link
Member

@Nepomuceno Nepomuceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ross-p-smith ross-p-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Chinedum!

@cecheta cecheta requested review from a team and removed request for a team July 12, 2024 14:09
@cecheta cecheta added the Class: Pattern Module 📦 This is a pattern module label Jul 16, 2024
@AlexanderSehr AlexanderSehr merged commit 0dcaa30 into Azure:main Jul 17, 2024
4 checks passed
@cecheta cecheta deleted the cecheta/ai-platform-pattern branch July 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants