Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/storage/storage-account Added service endpoints to output #2551

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

donheerschap
Copy link
Contributor

Description

Adding service endpoints of the storage account to the outputs to use in reference in other modules.

Closes #2550

Pipeline Reference

avm.res.storage.storage-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@donheerschap donheerschap requested review from a team as code owners June 26, 2024 12:37

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 26, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@donheerschap donheerschap changed the title feat: <avm/res/storage/storage-account> Added service endpoints to output feat: avm/res/storage/storage-account Added service endpoints to output Jun 26, 2024
@donheerschap
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ktremain ktremain marked this pull request as draft June 28, 2024 14:07
@ktremain ktremain marked this pull request as ready for review June 28, 2024 14:07
@ktremain ktremain closed this Jun 28, 2024
@ktremain ktremain reopened this Jun 28, 2024
@ktremain ktremain self-assigned this Jun 28, 2024
@ktremain ktremain added Type: Feature Request ➕ New feature or request Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 28, 2024
@ktremain ktremain merged commit c681a1d into Azure:main Jul 1, 2024
17 of 18 checks passed
@donheerschap donheerschap deleted the stgUriOutputs branch July 1, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Add storage account service endpoints to output to use for other modules
2 participants