Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Various bugfixes for VMSS module #2540

Merged
merged 21 commits into from
Jul 10, 2024
Merged

fix: Various bugfixes for VMSS module #2540

merged 21 commits into from
Jul 10, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Jun 24, 2024 •
edited
Loading

@rahalan rahalan added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jun 24, 2024
@rahalan rahalan self-assigned this Jun 24, 2024
@rahalan rahalan linked an issue Jun 24, 2024 that may be closed by this pull request
[AVM Module Issue]: Doc bug nicConfigurations in Microsoft.Compute/virtualMachineScaleSets #1851
Closed
1 task
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 24, 2024
@rahalan rahalan linked an issue Jun 24, 2024 that may be closed by this pull request
[Bicep-Virtual Machine Scale set AVM Review Feedback by VMSS PG] Best practices to be followed #2304
Closed
@rahalan rahalan marked this pull request as ready for review June 25, 2024 07:10
@rahalan rahalan requested review from a team as code owners June 25, 2024 07:10
@rahalan rahalan enabled auto-merge (squash) June 25, 2024 10:59
@rahalan rahalan added Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Module Owner 📣 This module needs an owner to develop or maintain it and removed Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Jun 25, 2024
@rahalan rahalan requested a review from a team as a code owner July 9, 2024 10:55
@rahalan rahalan disabled auto-merge July 9, 2024 14:57
@rahalan rahalan marked this pull request as draft July 9, 2024 14:57
@eriqua eriqua added Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Triage 🔍 Maintainers need to triage still labels Jul 10, 2024
@rahalan rahalan marked this pull request as ready for review July 10, 2024 08:52
@rahalan rahalan enabled auto-merge (squash) July 10, 2024 08:53
@rahalan rahalan merged commit 13fe2f7 into Azure:main Jul 10, 2024
4 checks passed
@rahalan rahalan deleted the users/rahalan/UpdateVMSS branch July 29, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@rahalan rahalan

Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
3 participants
@rahalan @AlexanderSehr @eriqua