Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hybrid-compute/machine module #2470

Merged
merged 27 commits into from
Jun 21, 2024

Conversation

mbrat2005
Copy link
Contributor

Description

Initial PR for hybrid-compute/machine module per Azure/Azure-Verified-Modules#931

Pipeline Reference

image

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 18, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jun 18, 2024
@mbrat2005 mbrat2005 changed the title hybrid-compute/machine module feat: hybrid-compute/machine module Jun 18, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 19, 2024
@mbrat2005 mbrat2005 marked this pull request as ready for review June 19, 2024 19:41
@mbrat2005 mbrat2005 requested review from a team as code owners June 19, 2024 19:41
@matebarabas matebarabas added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jun 20, 2024
@AlexanderSehr
Copy link
Contributor

Hey there, thanks for the great contribution, and immediate response to the suggestions and comments.
2 final asks: Please re-run the test pipeline on your end again after running the Set-AVMModule on the module, now that all changes are addressed.
And the other would be to please only resolve comments if they are suggestions (which can directly be committed) as it makes a re-review easier if the comment creator resolved the comment 😊 just a short reply on the comment that it was addressed would be enough.

@mbrat2005
Copy link
Contributor Author

Thanks @AlexanderSehr! I ran the Set-AVMModule script.

For the comment on resolving conversations...is that if the conversation is only a code suggestion (no text)?

@AlexanderSehr
Copy link
Contributor

Thanks @AlexanderSehr! I ran the Set-AVMModule script.

For the comment on resolving conversations...is that if the conversation is only a code suggestion (no text)?

Let me use some screenshots to illustrate. If a anybody adds a suggestion it looks like this, and via the Commit suggestion button it is directly commited to the branch and the comment is auto-resolved (no matter if there is other text or not):
image

General comments/asks looks like the following
image
and are the ones where it would be great if there're just responded to and be resolved by the person that originally created the comment as the solution (unless rejected) can take any shape or form.

@AlexanderSehr AlexanderSehr merged commit 33eb4d1 into Azure:main Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants