Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjusted telemetry 'deployments' suppression (letters A-D) #2353

Closed
wants to merge 200 commits into from
Closed

feat: Adjusted telemetry 'deployments' suppression (letters A-D) #2353

wants to merge 200 commits into from

Conversation

AlexanderSehr
Copy link
Contributor

Description

This PR only covers the modules starting with letters A-D

  • Added deployments suppression to module instead of just bicepconfig to also apply to anybody using our modules without a likewise configure bicepconfig locally
  • Updated used deployment RP API version
  • Formatted all templates
  • Regenerated all templates & readmes (due to API update)

New attempt after #1480

Pipeline Reference

Pipeline
avm.res.analysis-services.server

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

ReneHezser
ReneHezser previously approved these changes Jun 17, 2024
tony-box
tony-box previously approved these changes Jun 17, 2024
@ChrisSidebotham ChrisSidebotham removed the Needs: Triage 🔍 Maintainers need to triage still label Jun 18, 2024
@ChrisSidebotham ChrisSidebotham self-assigned this Jun 18, 2024
arnoldna
arnoldna previously approved these changes Jun 18, 2024
@AlexanderSehr AlexanderSehr added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jun 18, 2024
@AlexanderSehr AlexanderSehr marked this pull request as draft June 18, 2024 22:42
AlexanderSehr added a commit that referenced this pull request Jul 4, 2024
…2498)

## Description

Updated reamining templates with deployment-linter suppression

Replaces
- #2355
- #2353

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Maher Aldineh <[email protected]>
AlexanderSehr added a commit that referenced this pull request Jul 5, 2024
#2356)

## Description

This PR should only be merged after
- #2350
- #2353 
- #2354 
- #2355 
- #2498 

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.