feat: additional parameters, including CMK, for avm/res/net-app/net-app-account
#2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
|
@microsoft-github-policy-service agree [company="Linklaters"] |
bobmclane999
changed the title
bobmclane999
changed the title
eriqua
reviewed
May 29, 2024
Align to AVM Spec and use CDT for CMK
eriqua
added
Needs: Module Owner 📣
eriqua
reviewed
Jun 6, 2024
eriqua
changed the title
avm/res/net-app/net-app-account
removed test statement
|
@microsoft-github-policy-service agree [company="Linklaters"] |
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree company="Linklaters" |
|
@microsoft-github-policy-service agree company=Linklaters |
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this pull request
Jun 19, 2024
…app-account` (Azure#2089) ## Description <!-- Added support for CMK. Closes Azure#2089 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/bobmclane999/bicep-registry-modules/actions/workflows/avm.res.net-app.net-app-account.yml) | See this run: https://github.com/bobmclane999/bicep-registry-modules/actions/runs/9418453527 ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Jack Tracey <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
](https://github.com/bobmclane999/bicep-registry-modules/actions/workflows/avm.res.net-app.net-app-account.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline Reference
See this run: https://github.com/bobmclane999/bicep-registry-modules/actions/runs/9418453527
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.