Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for multiple custom domains in AFD endpoints + removing deprecated Akamai SKU for CDN profiles - avm/res/cdn/profile #2014

Merged
merged 17 commits into from
May 28, 2024

Conversation

gbeaud
Copy link
Contributor

@gbeaud gbeaud commented May 23, 2024

Description

Fixes #1639
Closes #1639

Pipeline Reference

avm.res.cdn.profile

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@gbeaud gbeaud requested review from a team as code owners May 23, 2024 09:32

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels May 23, 2024

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

@gbeaud gbeaud changed the title Adding support for multiple custom domains in AFD endpoints + removing deprecated Akamai SKU for CDN profiles feat: Adding support for multiple custom domains in AFD endpoints + removing deprecated Akamai SKU for CDN profiles May 23, 2024
@matebarabas matebarabas changed the title feat: Adding support for multiple custom domains in AFD endpoints + removing deprecated Akamai SKU for CDN profiles feat: Adding support for multiple custom domains in AFD endpoints + removing deprecated Akamai SKU for CDN profiles - avm/res/cdn/profile May 23, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels May 23, 2024
@AlexanderSehr AlexanderSehr self-requested a review May 24, 2024 06:57
.gitignore Outdated Show resolved Hide resolved
@AlexanderSehr AlexanderSehr merged commit 846c9b7 into Azure:main May 28, 2024
5 checks passed
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Jun 19, 2024
…emoving deprecated Akamai SKU for CDN profiles - `avm/res/cdn/profile` (Azure#2014)

## Description

- Adding support for multiple custom domains in AFD endpoint routes
(feature request Azure#1639 )
- Removing deprecated Akamai SKU for CDN profiles
- This is introducing breaking changes therefor creating a new version
0.3

Fixes Azure#1639 
Closes Azure#1639 

## Pipeline Reference


[![avm.res.cdn.profile](https://github.com/gbeaud/bicep-registry-modules/actions/workflows/avm.res.cdn.profile.yml/badge.svg?branch=main)](https://github.com/gbeaud/bicep-registry-modules/actions/workflows/avm.res.cdn.profile.yml)

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [X] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [X] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [X] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [X] My corresponding pipelines / checks run clean and green without
any errors or warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
3 participants