Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New pattern avm/ptn/authorization/resource-role-assignment #1905

Merged
merged 12 commits into from
May 15, 2024

Conversation

peterbud
Copy link
Contributor

@peterbud peterbud commented May 10, 2024

Description

Adding new pattern avm/ptn/authorization/resource-role-assignment

Azure/Azure-Verified-Modules#939

Migration of modules/authorization/resource-scope-role-assignment

Closes #937

Pipeline Reference

Pipeline
avm.ptn.authorization.resource-role-assignment

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@peterbud peterbud requested review from a team as code owners May 10, 2024 06:52
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels May 10, 2024
@AlexanderSehr AlexanderSehr changed the title feat: New pattern avm/ptn/authrization/resource-role-assignment feat: New pattern avm/ptn/authorization/resource-role-assignment May 11, 2024
@AlexanderSehr
Copy link
Contributor

Note, for this and all other changes, I'd recommend to re-run Set-AvmModule -ModuleFolderPath '.\avm\ptn\authorization\resource-role-assignment' -SkipFileAndFolderSetup -ThrottleLimit 5 -Recurse

just bubbling this up in its own comment for awareness

@peterbud peterbud force-pushed the resource-role-assignment branch from 06f046e to 02d2d48 Compare May 13, 2024 16:03
@matebarabas matebarabas added Class: Pattern Module 📦 This is a pattern module and removed Needs: Triage 🔍 Maintainers need to triage still labels May 13, 2024
@matebarabas matebarabas added the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready or aligned to future direction etc. label May 14, 2024
@matebarabas
Copy link
Contributor

@peterbud, @AlexanderSehr, please note that this module has just been filed for addition into the MAR/MCR manifest. Please do not attempt to publish this module, until its addition is confirmed (I'll let you know when the MCR PR is merged). Thank you!

@matebarabas matebarabas removed the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready or aligned to future direction etc. label May 15, 2024
@matebarabas
Copy link
Contributor

@peterbud, @AlexanderSehr, please note that this module has just been filed for addition into the MAR/MCR manifest. Please do not attempt to publish this module, until its addition is confirmed (I'll let you know when the MCR PR is merged). Thank you!

@peterbud, @AlexanderSehr, this module has now been added to the MAR manifest. Please feel free to proceed with the review/publication as per the standard process. Thanks!

@AlexanderSehr AlexanderSehr merged commit 9ad5ba4 into Azure:main May 15, 2024
7 checks passed
@peterbud peterbud deleted the resource-role-assignment branch May 16, 2024 06:48
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Jun 19, 2024
…zure#1905)

## Description

Adding new pattern `avm/ptn/authorization/resource-role-assignment`

Azure/Azure-Verified-Modules#939

Migration of `modules/authorization/resource-scope-role-assignment`

Closes Azure#937

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.authorization.resource-role-assignment](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.ptn.authorization.resource-role-assignment.yml/badge.svg?branch=resource-role-assignment)](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.ptn.authorization.resource-role-assignment.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Selective Role Assignment Modification for Existing Storage Accounts
3 participants