Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sql mi missing v2 formatting - avm/res/sql/managed-instance #1857

Merged
merged 8 commits into from
May 22, 2024

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented May 6, 2024

Description

Reformatting sql mi bicep template and test files to v2

Pipeline Reference

Pipeline
avm.res.sql.managed-instance

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@eriqua eriqua self-assigned this May 6, 2024
@eriqua eriqua requested review from a team as code owners May 6, 2024 22:19
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels May 6, 2024
@eriqua eriqua enabled auto-merge (squash) May 6, 2024 22:20
@matebarabas matebarabas changed the title fix: sql mi missing v2 formatting fix: sql mi missing v2 formatting - avm/res/sql/managed-instance May 7, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels May 7, 2024
@AlexanderSehr
Copy link
Contributor

Hey @maldineh, please take a lot when you have the chance :)

@eriqua eriqua merged commit fc9a1cd into Azure:main May 22, 2024
5 checks passed
@AlexanderSehr AlexanderSehr deleted the fix/sqlmi-v2-format branch May 24, 2024 06:19
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Jun 19, 2024
## Description

Reformatting sql mi bicep template and test files to v2

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.sql.managed-instance](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.sql.managed-instance.yml/badge.svg?branch=fix%2Fsqlmi-v2-format)](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.sql.managed-instance.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants