feat: Removed enforcement of UDT schemas for pattern modules #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
changed the title
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
AlexanderSehr
changed the title
eriqua
reviewed
May 6, 2024
Agazoth
pushed a commit
to Agazoth/bicep-registry-modules
that referenced
this pull request
May 13, 2024
) ## Description Skipping UDT tests for Pattern modules Closes Azure#1749 Example Resource (note the UDT schema tests)  Example Pattern (note the lack of UDT schema tests)  ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml) | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.aad.domain-service.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this pull request
Jun 19, 2024
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml){kind=link}
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.aad.domain-service.yml){kind=link}
) ## Description Skipping UDT tests for Pattern modules Closes Azure#1749 Example Resource (note the UDT schema tests)  Example Pattern (note the lack of UDT schema tests)  ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml) | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.aad.domain-service.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skipping UDT tests for Pattern modules
Closes #1749
Example Resource (note the UDT schema tests)
Example Pattern (note the lack of UDT schema tests)
Pipeline Reference
Type of Change
version.json:version.json.version.json.