fix: Allow empty parameters in subnet avm/res/network/virtual-network

[cloudchristoph]

Description

You cannot provide the following parameters in your subnet parameter, if they are empty:

• networkSecurityGroup
• natGateway
• routeTable

As soon as they are set, they have to have a correct resource id.

This PR implements additional checks for given, but empty, parameters.
I also added a new subnet definition in the max test to check for the correct behaviour.

Fixes #1681
Closes #1681

Pipeline Reference

Pipeline

Type of Change

• Update to CI Environment or utilities (Non-module effecting changes)
• Azure Verified Module updates:
  • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

[microsoft-github-policy-service]

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

[elbatane]

Hi @cloudchristoph , would you mind to add the !empty also for: privateEndpointNetworkPolicies and privateLinkServiceNetworkPolicies? To set the subnet within the vnet the same way we have inside the subnet module (

bicep-registry-modules/avm/res/network/virtual-network/subnet/main.bicep

Line 104 in 0509c53

privateEndpointNetworkPolicies: !empty(privateEndpointNetworkPolicies) ? any(privateEndpointNetworkPolicies) : null

) . Thank you very much

[cloudchristoph]

Hi @cloudchristoph , would you mind to add the !empty also for: privateEndpointNetworkPolicies and privateLinkServiceNetworkPolicies? To set the subnet within the vnet the same way we have inside the subnet module (

bicep-registry-modules/avm/res/network/virtual-network/subnet/main.bicep

Line 104 in 0509c53

privateEndpointNetworkPolicies: !empty(privateEndpointNetworkPolicies) ? any(privateEndpointNetworkPolicies) : null

) . Thank you very much

Sure. But for this parameter and the others you're already allowed to give an empty array or null as value and it still works. This wasn't the case for the three changed parameters.

Correct me, if I'm wrong.

I would like to ask one more question:
What will be allowed as an as “not set parameter”? Now it is a mixture of '', null, and [].

[AlexanderSehr]

Hey @elbatane, the PR looks good to me. Please also take a look :)