Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Diverse ReadMe utility fixes #1768

Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Apr 27, 2024

Description

  • Updated path regex to search for 'avm/res|ptninstead of onlyavmto allow the folder nameavm` in other parts of file paths
  • Have readme utility ignore commented lines found in the testDeployment params block
  • Have readme utility throw an exception if any parameter in the processed template files does not contain the required category (e.g., 'Required.') in its description to avoid misleading sideeffects

Reran utility across all templates... which as expected did not cause any changes

Example output for incorrect parameters:
========================================
Exception: C:\dev\ip\\avm\utilities\pipelines\sharedScripts\Set-ModuleReadMe.ps1:260:9
Line |
 260 |          throw ("Each parameter description should start with a catego …
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Each parameter description should start with a category like [Required. / Optional. / Conditional. ]. The following parameters are missing such a category:  [{"name":"name","description":"Name of the 
     | Key Vault. Must be globally unique."},{"name":"secrets","description":"All secrets to create."}]Branch : users/alsehr/1761_readMeSupportComments

Pipeline Reference

Pipeline
avm.res.key-vault.vault

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 27, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Apr 27, 2024

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

@AlexanderSehr AlexanderSehr self-assigned this Apr 27, 2024
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working and removed Needs: Triage 🔍 Maintainers need to triage still labels Apr 27, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review April 27, 2024 11:29
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner April 27, 2024 11:29
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 27, 2024 11:29
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 8f0e510 into Azure:main Apr 30, 2024
5 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1761_readMeSupportComments branch April 30, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
2 participants