Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add v2 skus to api-management/service #1755

Closed
wants to merge 0 commits into from

Conversation

tony-box
Copy link
Contributor

@tony-box tony-box commented Apr 26, 2024

Description

Adding capability for v2 APIM skus

Fixes #1615

Pipeline Reference

Pipeline
avm.res.api-management.service

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@tony-box tony-box requested review from a team as code owners April 26, 2024 04:14
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Apr 26, 2024
@tony-box tony-box changed the title V2skus fix: add v2 skus to api-management/service Apr 26, 2024
@tony-box tony-box enabled auto-merge (squash) April 26, 2024 04:16
Copy link
Contributor

@eriqua eriqua Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tony-box security center changes sneaked in. Let's have a clean diff including only apim changes.

Apart from that looks good

@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Apr 26, 2024
@tony-box tony-box closed this Apr 29, 2024
auto-merge was automatically disabled April 29, 2024 18:20

Pull request was closed

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Apr 29, 2024

oh my @tony-box, what happened? 😄 I see a force-push bomb shell

@tony-box
Copy link
Contributor Author

@AlexanderSehr oh man, I think the stupid auto-merge thing in github did this. I was attempting to update my fork's v2sku branch to the latest commit from upstream so that it would resolve the accidental commits that snuck in related to security-center. I should have just used my tried and true CLI. Let me sort this out and reopen the PR. Sorry about that!

@AlexanderSehr
Copy link
Contributor

Github does force pushes? 😅 Let me know if I can help - especially if you lost progress. 👀

@tony-box
Copy link
Contributor Author

When your fork or branch is out of date from upstream, there's an option in the UI to sync your fork with the upstream. If there are merge conflicts, it'll let you to do something like "revert changes" or "discard commits"--cant remember exactly. I think when I clicked one of those it force pushed to my fork to get rid of all my changes.

I've got it under control though. Updating my branch now :)

@tony-box
Copy link
Contributor Author

tony-box commented Apr 30, 2024

This PR was never merged and is defunct.

I recreated this PR as #1777 just to keep everything clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: API Management Service - Please support API Management V2 SKUs
3 participants