-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add v2 skus to api-management/service #1755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony-box security center changes sneaked in. Let's have a clean diff including only apim changes.
Apart from that looks good
Pull request was closed
oh my @tony-box, what happened? 😄 I see a |
@AlexanderSehr oh man, I think the stupid auto-merge thing in github did this. I was attempting to update my fork's v2sku branch to the latest commit from upstream so that it would resolve the accidental commits that snuck in related to security-center. I should have just used my tried and true CLI. Let me sort this out and reopen the PR. Sorry about that! |
Github does force pushes? 😅 Let me know if I can help - especially if you lost progress. 👀 |
When your fork or branch is out of date from upstream, there's an option in the UI to sync your fork with the upstream. If there are merge conflicts, it'll let you to do something like "revert changes" or "discard commits"--cant remember exactly. I think when I clicked one of those it force pushed to my fork to get rid of all my changes. I've got it under control though. Updating my branch now :) |
This PR was never merged and is defunct. I recreated this PR as #1777 just to keep everything clean |
Description
Adding capability for v2 APIM skus
Fixes #1615
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.