feat: add option for keda addon container-service - avm/res/container-service/managed-cluster
#1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. Note This label was added as per ITA06. |
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
|
Note The "Type: AVM |
PixelRobots
changed the title
|
@PixelRobots The PR diff is showing changes from your cost-analysis PR as well. Can you please clean this up? |
|
That should be resolved now. |
Signed-off-by: PixelRobots <[email protected]>
Signed-off-by: PixelRobots <[email protected]>
|
@PixelRobots code looks good now. Just need to get a green pipeline and we can merge this. |
|
It's a strange one. One of the jobs keeps failing. All others are ok. I think it might be something I am doing but not an issue with the bicep. Any ideas? |
matebarabas
changed the title
avm/res/container-service/managed-cluster
matebarabas
added
Class: Resource Module 📦
|
And we have green! Seems it was an Azure region and it was being slow or something. |
ilhaan
approved these changes
Apr 18, 2024
donk-msft
pushed a commit
to donk-msft/bicep-registry-modules
that referenced
this pull request
Apr 29, 2024
…r-service/managed-cluster` (Azure#1691) ## Description This is adding in the option to enable Keda on an AKS cluster. I would probably do this one after Azure#1682 as i used my main branch that has the cost anlayasis changes in it. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#123 Fixes Azure#456 Closes Azure#123 Closes Azure#456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/PixelRobots/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml?query=branch%3Afeat-Keda) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [X] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [X] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Signed-off-by: PixelRobots <[email protected]>
](https://github.com/PixelRobots/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml?query=branch%3Afeat-Keda){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is adding in the option to enable Keda on an AKS cluster.
I would probably do this one after #1682 as i used my main branch that has the cost anlayasis changes in it.
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.