Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pwsh publish module index #1683

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: pwsh publish module index #1683

merged 1 commit into from
Apr 15, 2024

Conversation

jtracey93
Copy link
Contributor

Description

Removing an unnecessary -Force and unrequired SupportsShouldProcess from the Invoke-AvmJsonModuleIndexGeneration.ps1

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jtracey93 jtracey93 requested review from a team as code owners April 15, 2024 15:31
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 15, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Apr 15, 2024
@AlexanderSehr AlexanderSehr merged commit 46d965b into Azure:main Apr 15, 2024
9 checks passed
sebassem added a commit to sebassem/bicep-registry-modules that referenced this pull request Apr 17, 2024
…mit messages in this repository:

1. added readme
2. feat: Added UDTs for disks and ability to give a custom name to a disk - `avm/res/compute/virtual-machine` (Azure#1517)
3. Merge branch 'Azure:main' into avm-ptn-alz-sub-vending
4. fix: Dnsrule bug for virtual Network link name (Azure#1538)
5. fix: prevent updating the workspace repository configuration whenever no value is provided, so an existing configuration is not overwritten. (Azure#1680)
6. fix: WAF reliability and static validation in `avm/res/web/site`  (Azure#1427)
7. fix: Update for default WAF-alignment - `avm/res/cache/redis` (Azure#1621)
8. Merge branch 'Azure:main' into avm-ptn-alz-sub-vending
9. fix: pwsh publish module index (Azure#1683)
10. feat: Added UDTs for disks and ability to give a custom name to a disk - `avm/res/compute/virtual-machine` (Azure#1517)
segraef pushed a commit to segraef/bicep-registry-modules that referenced this pull request Apr 17, 2024
## Description

Removing an unnecessary `-Force` and unrequired `SupportsShouldProcess`
from the `Invoke-AvmJsonModuleIndexGeneration.ps1`

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [ ] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants