-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updates base image and adds features the nice way, allows local testing #1406
Conversation
@segraef - Are you happy with this? |
Yup, much more cleaner way, thanks @ReneHezser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing @segraef, will approve on that basis.
And of course thank you @ReneHezser for the contribution 💪
Dang, prettier takes offense. Very likely because of the file ending: @ReneHezser could you take care of this? |
I don't get it. I ran prettier and the file has an empty line at the end. I checked that one in, but the action still complains ¯\(ツ)/¯ |
@ChrisSidebotham, I think you know more about prettier than me 😄 Would you happen to have any advice? Maybe we can just bypass it by taking the workflow out of the policy as we may or may not retire it anyhow. |
Note The "Type: AVM |
From my understanding this happens when your editor switches from CRLF to LF and prettier doesn't like it, but we never managed to confirm that |
Closing and Re-opening to re-trigger the workflow validation... |
I'm impressed. Even by removing the workflow requirement and re-opening the PR the check prevails. @ReneHezser at this point the only solution I'm seeing is to open a new PR from the same branch you opened this one from. Could you give that a shot? |
I am testing Prettier and its discomfort with this file anyway. CRLF is not the problem. |
Description
Updates devcontainer
Pipeline Reference
not needed
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.