Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1341 IR description passthrough #1343

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

clintgrove
Copy link
Contributor

@clintgrove clintgrove commented Mar 20, 2024

Description

The IR description was left out of the main parent bicep file

Fixes #1341
Closes #1341
-->

Pipeline Reference

Pipeline
avm.res.data-factory.factory

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 20, 2024
@clintgrove clintgrove changed the title bugfix: 1341 IR description passthrough fix: 1341 IR description passthrough Mar 20, 2024
@clintgrove clintgrove added Bug Fix and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 20, 2024
@clintgrove clintgrove marked this pull request as ready for review March 20, 2024 13:04
@clintgrove clintgrove requested review from a team as code owners March 20, 2024 13:04
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisSidebotham ChrisSidebotham enabled auto-merge (squash) March 20, 2024 17:15
@ChrisSidebotham ChrisSidebotham merged commit ed897c0 into Azure:main Mar 20, 2024
8 checks passed
@clintgrove clintgrove deleted the irdescpassthrough branch March 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Data-Factory IR description passthrough missing interagrationRuntimeCustomDescription
2 participants