-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Module avm/res/signal-r-service/signal-r
#1109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cep-registry-modules into users/krbar/signalRModule
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
labels
Mar 1, 2024
avm/res/signal-r-service/signal-r/tests/e2e/max/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/signal-r-service/signal-r/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
segraef
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments to what @AlexanderSehr already marked
…into users/krbar/signalRModule
2 tasks
…into users/krbar/signalRModule
AlexanderSehr
approved these changes
Mar 11, 2024
4 tasks
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this pull request
Mar 12, 2024
## Description New Module `avm/res/signal-r-service/signal-r`, migrated from CARML. ## Adding a new module <!--Run through the checklist if your PR adds a new module.--> - [x] A proposal has been submitted and approved. - [ ] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. ## Pipeline references | Pipeline | | - | | [![avm.res.signal-r-service.signal-r](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml/badge.svg?branch=users%2Fkrbar%2FsignalRModule)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Module
avm/res/signal-r-service/signal-r
, migrated from CARML.Adding a new module
brm validate
locally to verify the module files.Pipeline references