Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update PE implementation in alignment to latest schema (2) #1089

Merged
merged 28 commits into from
Mar 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c12dc1b
PE adjustments (#1070)
segraef Feb 25, 2024
3a2572a
Update to latest
AlexanderSehr Feb 25, 2024
f510b12
Several fixes
AlexanderSehr Feb 25, 2024
ef334ce
More updates
AlexanderSehr Feb 25, 2024
ad38957
Expanded tests
AlexanderSehr Feb 25, 2024
e11cbd9
Refreshed JSON
AlexanderSehr Feb 25, 2024
7989ce0
Update to latest
AlexanderSehr Feb 25, 2024
a96d94b
Added missing tryGet
AlexanderSehr Feb 25, 2024
54ba237
Updated site docs
AlexanderSehr Feb 25, 2024
080fa8e
Merged latest main
AlexanderSehr Feb 25, 2024
a2d88ab
Update to latest
AlexanderSehr Feb 25, 2024
3aa7a03
Update to latest
AlexanderSehr Feb 25, 2024
e3fefb6
Update to latest
AlexanderSehr Feb 25, 2024
ff0819c
Update to latest
AlexanderSehr Feb 25, 2024
6e8af04
Update to latest
AlexanderSehr Feb 25, 2024
b06858d
Fixed incorrect groupId for synapse privateLinkHub
AlexanderSehr Feb 25, 2024
e79edcb
feat: added additional PE tests (#1077)
segraef Feb 26, 2024
c867e8e
Update to latest
AlexanderSehr Feb 26, 2024
a98d5f6
Update to latest
AlexanderSehr Feb 26, 2024
ee1ceb9
Update to latest
AlexanderSehr Feb 26, 2024
b703187
Update to latest
AlexanderSehr Feb 26, 2024
b86b2db
Regen docs
AlexanderSehr Feb 26, 2024
47a42d4
Updated tests with explicit dependency
AlexanderSehr Feb 26, 2024
846b512
Added explicit dependencies
AlexanderSehr Feb 26, 2024
3befb25
Update to latest
AlexanderSehr Feb 26, 2024
8805574
Update to latest
AlexanderSehr Feb 26, 2024
b6dbfb9
Merge branch 'main' into feat/pe-adjustments-962-946-1042
AlexanderSehr Feb 27, 2024
a5f2239
Update to latest
AlexanderSehr Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update to latest
AlexanderSehr committed Feb 26, 2024
commit a98d5f68bbce46c2acf6ab126ccc4b142a58efb6
4 changes: 2 additions & 2 deletions avm/res/databricks/workspace/tests/e2e/max/dependencies.bicep
Original file line number Diff line number Diff line change
@@ -341,10 +341,10 @@ resource privateDNSZone 'Microsoft.Network/privateDnsZones@2020-06-01' = {
output defaultSubnetResourceId string = virtualNetwork.properties.subnets[0].id

@description('The name of the 2nd created Virtual Network Public Subnet.')
output customPublicSubnetName string = virtualNetwork.properties.subnets[1].name
output customPublicSubnetResourceId string = virtualNetwork.properties.subnets[1].name

@description('The name of the 3rd created Virtual Network Private Subnet.')
output customPrivateSubnetName string = virtualNetwork.properties.subnets[2].name
output customPrivateSubnetResourceId string = virtualNetwork.properties.subnets[2].name

@description('The resource ID of the created Virtual Network.')
output virtualNetworkResourceId string = virtualNetwork.id
10 changes: 5 additions & 5 deletions avm/res/databricks/workspace/tests/e2e/max/main.test.bicep
Original file line number Diff line number Diff line change
@@ -139,8 +139,8 @@ module testDeployment '../../../main.bicep' = [for iteration in [ 'init', 'idem'
requiredNsgRules: 'NoAzureDatabricksRules'
skuName: 'premium'
amlWorkspaceResourceId: nestedDependencies.outputs.machineLearningWorkspaceResourceId
customPrivateSubnetName: nestedDependencies.outputs.customPrivateSubnetName
customPublicSubnetName: nestedDependencies.outputs.customPublicSubnetName
customPrivateSubnetName: nestedDependencies.outputs.customPrivateSubnetResourceId
customPublicSubnetName: nestedDependencies.outputs.customPublicSubnetResourceId
publicNetworkAccess: 'Disabled'
disablePublicIp: true
loadBalancerResourceId: nestedDependencies.outputs.loadBalancerResourceId
@@ -152,7 +152,7 @@ module testDeployment '../../../main.bicep' = [for iteration in [ 'init', 'idem'
nestedDependencies.outputs.privateDNSZoneResourceId
]
service: 'databricks_ui_api'
subnetResourceId: nestedDependencies.outputs.customPublicSubnetName
subnetResourceId: nestedDependencies.outputs.customPublicSubnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
@@ -163,7 +163,7 @@ module testDeployment '../../../main.bicep' = [for iteration in [ 'init', 'idem'
nestedDependencies.outputs.privateDNSZoneResourceId
]
service: 'databricks_ui_api'
subnetResourceId: nestedDependencies.outputs.customPrivateSubnetName
subnetResourceId: nestedDependencies.outputs.customPrivateSubnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
@@ -173,7 +173,7 @@ module testDeployment '../../../main.bicep' = [for iteration in [ 'init', 'idem'
privateDnsZoneResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
subnetResourceId: nestedDependencies.outputs.customPrivateSubnetName
subnetResourceId: nestedDependencies.outputs.customPrivateSubnetResourceId
service: 'browser_authentication'
}
]
Original file line number Diff line number Diff line change
@@ -340,11 +340,11 @@ resource privateDNSZone 'Microsoft.Network/privateDnsZones@2020-06-01' = {
@description('The resource ID of the created Virtual Network Default Subnet.')
output defaultSubnetResourceId string = virtualNetwork.properties.subnets[0].id

@description('The name of the created Virtual Network Public Subnet.')
output customPublicSubnetName string = virtualNetwork.properties.subnets[1].name
@description('The name of the 2nd created Virtual Network Public Subnet.')
output customPublicSubnetResourceId string = virtualNetwork.properties.subnets[1].name

@description('The name of the created Virtual Network Private Subnet.')
output customPrivateSubnetName string = virtualNetwork.properties.subnets[2].name
@description('The name of the 3rd created Virtual Network Private Subnet.')
output customPrivateSubnetResourceId string = virtualNetwork.properties.subnets[2].name

@description('The resource ID of the created Virtual Network.')
output virtualNetworkResourceId string = virtualNetwork.id
Original file line number Diff line number Diff line change
@@ -122,8 +122,8 @@ module testDeployment '../../../main.bicep' = [for iteration in [ 'init', 'idem'
requiredNsgRules: 'NoAzureDatabricksRules'
skuName: 'premium'
amlWorkspaceResourceId: nestedDependencies.outputs.machineLearningWorkspaceResourceId
customPrivateSubnetName: nestedDependencies.outputs.customPrivateSubnetName
customPublicSubnetName: nestedDependencies.outputs.customPublicSubnetName
customPrivateSubnetName: nestedDependencies.outputs.customPrivateSubnetResourceId
customPublicSubnetName: nestedDependencies.outputs.customPublicSubnetResourceId
publicNetworkAccess: 'Disabled'
disablePublicIp: true
loadBalancerResourceId: nestedDependencies.outputs.loadBalancerResourceId