-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added post-deployment test support #1036
Merged
AlexanderSehr
merged 128 commits into
Azure:main
from
AlexanderSehr:users/alsehr/postDeploymentTest
Mar 5, 2024
Merged
feat: Added post-deployment test support #1036
AlexanderSehr
merged 128 commits into
Azure:main
from
AlexanderSehr:users/alsehr/postDeploymentTest
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.ps1 Co-authored-by: Erika Gressi <[email protected]>
…ts.ps1 Co-authored-by: Erika Gressi <[email protected]>
1 task
AlexanderSehr
commented
Feb 27, 2024
fblix
previously approved these changes
Feb 28, 2024
ChrisSidebotham
previously approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
AlexanderSehr
dismissed stale reviews from ChrisSidebotham and fblix
via
March 4, 2024 18:16
515baba
ChrisSidebotham
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this pull request
Mar 12, 2024
## Description > **Note:** Test file changes for key vault are just for illustration purposes - Introduced 2 additional steps to deploy action that will look for Pester test files anywhere in a e2e test's folder (or nested folder, if desired), run the contained tests and publish the results - If no test was found, the publish results step will be skipped - By default, the action will pass in one parameter to the test files that MUST be implemented: `[hashtable] $TestInputData`. This parameter will automatically contain the test file outputs + the path to the test file. For example ```json { "TestInputData": { "ModuleTestFolderPath": "/home/runner/work/bicep-registry-modules/bicep-registry-modules/avm/res/key-vault/vault/tests/e2e/private-endpoint", "DeploymentOutputs": { "resourceId": { "type": "string", "value": "/subscriptions/1111111/resourcegroups/(...)" } } } } ``` - Example [run](https://github.com/AlexanderSehr/bicep-registry-modules/actions/runs/7944560531/job/21690223560) | Pipeline | | - | | [![avm.res.key-vault.vault](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=users%2Falsehr%2FpostDeploymentTest&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) | --------- Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: ChrisSidebotham-MSFT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[hashtable] $TestInputData
. This parameter will automatically contain the test file outputs + the path to the test file. For example