Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Missing diagnostic settings option on Front Door CDN profile #3876

Closed
1 task done
jonclyde opened this issue Dec 3, 2024 · 3 comments · Fixed by #3923
Closed
1 task done

[AVM Module Issue]: Missing diagnostic settings option on Front Door CDN profile #3876

jonclyde opened this issue Dec 3, 2024 · 3 comments · Fixed by #3923
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@jonclyde
Copy link

jonclyde commented Dec 3, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/cdn/profile

(Optional) Module Version

No response

Description

Hi,

I am using the the CDN profile AVM module to deploy Azure Front Door and need to enable diagnostic settings to a log analytics workspace. I require logs/metrics to be saved but most importantly the WAF logs to allow tuning.

I can't seem to see a way of doing this with the current version of module https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/cdn/profile/main.bicep.

Is this a feature that needs to be added? Are there any alternative methods for enabling diagnostics as a workaround?

Cheers

Jon

(Optional) Correlation Id

No response

@jonclyde jonclyde added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 3, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Dec 3, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Dec 3, 2024
Copy link

@jonclyde, thanks for submitting this issue for the avm/res/cdn/profile module!

Important

A member of the @Azure/avm-res-cdn-profile-module-owners-bicep or @Azure/avm-res-cdn-profile-module-contributors-bicep team will review it soon!

@gbeaud
Copy link
Contributor

gbeaud commented Dec 4, 2024

Hi @jonclyde, thanks for sharing this! The WAF policy for Front Door is in another module: https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/network/front-door-web-application-firewall-policy

I would suggest you raise a feature request on the other repo - hope this helps and please let me know if I can close the present issue 😊

@gbeaud gbeaud removed the Needs: Triage 🔍 Maintainers need to triage still label Dec 4, 2024
AlexanderSehr pushed a commit that referenced this issue Dec 18, 2024
…request #3876 (#3923)

## Description

- Adding diagnostic settings support to the CDN profile using the custom
type _diagnosticSettingFullType_ provided in
_'br/public:avm/utl/types/avm-common-types:0.4.0'_
- Removing the deprecated Verizon SKU (breaking change)

Closes #3876 


## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.cdn.profile](https://github.com/gbeaud/bicep-registry-modules/actions/workflows/avm.res.cdn.profile.yml/badge.svg?branch=FR%233876-DiagnosticSettings)](https://github.com/gbeaud/bicep-registry-modules/actions/workflows/avm.res.cdn.profile.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [x] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
2 participants