Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Missing FQDN being output from the avm/res/sql/server module #3820

Closed
1 task done
Fazer01 opened this issue Nov 20, 2024 · 3 comments · Fixed by #3863
Closed
1 task done

[AVM Module Issue]: Missing FQDN being output from the avm/res/sql/server module #3820

Fazer01 opened this issue Nov 20, 2024 · 3 comments · Fixed by #3863
Assignees
Labels
Class: Resource Module 📦 This is a resource module Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@Fazer01
Copy link

Fazer01 commented Nov 20, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/sql/server

(Optional) Module Version

0.10.1

Description

Hi,

I was wondering if the FQDN of the server can be added to the outputs?

Prior using the fantastic AVM way we were able to do something like the sqlServerFqdn1 property mentioned in the image below.

Image

Thanks in advance,
Regards,

Tom

(Optional) Correlation Id

No response

@Fazer01 Fazer01 added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 20, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Nov 20, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Nov 20, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Nov 20, 2024
Copy link

@Fazer01, thanks for submitting this issue for the avm/res/sql/server module!

Important

A member of the @Azure/avm-res-sql-server-module-owners-bicep or @Azure/avm-res-sql-server-module-contributors-bicep team will review it soon!

@Fazer01 Fazer01 changed the title [AVM Module Issue]: [AVM Module Issue]: Missing FQDN being output from the avm/res/sql/server module Nov 20, 2024
@peterbud
Copy link
Contributor

Yes, that would be feasible

@peterbud peterbud added Type: Feature Request ➕ New feature or request Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Needs: Triage 🔍 Maintainers need to triage still Type: Bug 🐛 Something isn't working labels Nov 20, 2024
AlexanderSehr pushed a commit that referenced this issue Nov 29, 2024
…3863)

Closes #3820

## Description

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.sql.server](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml/badge.svg)](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants