Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Add support for rest of the Workspace properties. #3087

Closed
1 task done
iliyansi opened this issue Aug 22, 2024 · 4 comments · Fixed by #3178
Closed
1 task done

[AVM Module Issue]: Add support for rest of the Workspace properties. #3087

iliyansi opened this issue Aug 22, 2024 · 4 comments · Fixed by #3178
Assignees
Labels
Class: Resource Module 📦 This is a resource module Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@iliyansi
Copy link

iliyansi commented Aug 22, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/databricks/workspace

(Optional) Module Version

No response

Description

When I try to deploy data bricks workspace and configure default catalog I don't see such parameter while on resource api there is defaultCatalog property of type DefaultPropertiesCatalog object which sets initialName and InitialType of that catalog. There is also missing parameter for enhancedSecurityCompliance property and authorization.

(Optional) Correlation Id

No response

@iliyansi iliyansi added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 22, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Copy link

@iliyansi, thanks for submitting this issue for the avm/res/databricks/workspace module!

Important

A member of the @Azure/avm-res-databricks-workspace-module-owners-bicep or @Azure/avm-res-databricks-workspace-module-contributors-bicep team will review it soon!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Aug 22, 2024
@clintgrove clintgrove removed the Needs: Triage 🔍 Maintainers need to triage still label Aug 26, 2024
@clintgrove
Copy link
Contributor

Hi. I am busy working on a fix for this. It will take about another week

@clintgrove
Copy link
Contributor

hi @iliyansi I have completed some work on this. PR is now open. One thing to note is that you cannot currently set the catalog name, the Resource Provider does not currently allow it. The thing you can set is whether its a HiveMetastore or a UnityCatalog. See how I have implemented it in the MAX version of the databricks deployment

@clintgrove clintgrove added the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Sep 10, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Sep 10, 2024
jianingwang123 pushed a commit to jianingwang123/bicep-registry-modules that referenced this issue Sep 12, 2024
## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.
-->
Fixes Azure#3087 
Closes Azure#3087 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.databricks.workspace](https://github.com/clintgrove/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml/badge.svg?branch=3807-issue-addcatalog)](https://github.com/clintgrove/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants