Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Machine Learning Module should add the creation of Microsoft.MachineLearningServices/workspaces/connections #2575

Closed
1 task done
Menghua1 opened this issue Jun 28, 2024 · 16 comments · Fixed by #3027
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@Menghua1
Copy link
Member

Menghua1 commented Jun 28, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/machine-learning-services/workspace

(Optional) Module Version

No response

Description

Please add the creation of Microsoft.MachineLearningServices/workspaces/connections.

For example (azd):

CC: @jongio

(Optional) Correlation Id

No response

@Menghua1 Menghua1 added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 28, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jun 28, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jun 28, 2024
Copy link

@Menghua1, thanks for submitting this issue for the avm/res/machine-learning-services/workspace module!

Important

Please note, that this module is currently orphaned. The @Azure/avm-core-team-technical-bicep, will attempt to find an owner for it. In the meantime, the core team may assist with this issue. Thank you for your patience!

@AlexanderSehr AlexanderSehr added Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 28, 2024
@AlexanderSehr
Copy link
Contributor

Hey @Menghua1, thanks for the issue.
The request makes absolute sense, hence I removed the 'Needs: Triage' label. However, as the module currently has no owner that would automatically be assigned to this issue, it may take a moment for the community to work on it. If you're up for the task you can of course also create the contribution yourself. 💪

@matebarabas
Copy link
Contributor

Good news, this module just got a new owner! @cecheta, can you please look into this issue? Thanks!

CC: @ross-p-smith as secondary owner

@matebarabas matebarabas removed the Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time label Jul 1, 2024
@cecheta
Copy link
Member

cecheta commented Jul 2, 2024

Thanks for raising this, we'll look into this in due course

@cecheta
Copy link
Member

cecheta commented Jul 9, 2024

Hi @Menghua1 , it looks like Microsoft.MachineLearningServices/workspaces/endpoint is deprecated now? I receive this error:

{
  "status": "Failed",
  "error": {
    "code": "DeploymentFailed",
    "target": "/subscriptions/***/resourceGroups/rg-dev/providers/Microsoft.Resources/deployments/main",
    "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
    "details": [
      {
        "code": "ValidationError",
        "message": "Endpoint resources are no longer supported, and have been migrated to connections. Please delete this resource and re-create it as a connection.",
        "details": []
      }
    ]
  }
}

Would it be ok to update the issue to just include connections?

@Menghua1
Copy link
Member Author

Menghua1 commented Jul 10, 2024

@jongio Any ideas about above comments? Could we consider only including connections in AVM?

@jongio
Copy link
Member

jongio commented Jul 10, 2024

@jongio Any ideas about above comments? Could we consider only including connections in AVM?

Please track down where this module is being use, who added it to infra/core, and then figure out a path forward.

@Menghua1
Copy link
Member Author

@jongio Any ideas about above comments? Could we consider only including connections in AVM?

Please track down where this module is being use, who added it to infra/core, and then figure out a path forward.

We did not find repo to use this module and @wbreza added this module to infra/core.

During the test, it looks like Microsoft.MachineLearningServices/workspaces/endpoint is deprecated now. Do you have any ideas about this?@wbreza

@jtracey93
Copy link
Contributor

@jongio, from the comments/chat here from @Menghua1 it looks like this one is maybe not needed, can you and the team confirm?

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Jul 12, 2024
@jongio
Copy link
Member

jongio commented Jul 15, 2024

Let's see what @wbreza says.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Jul 15, 2024
@wbreza
Copy link

wbreza commented Jul 15, 2024

endpoints are no longer supported and all new deployments must be migrated to connections. An example of this after a migration can be found in the AZD AI Studeio Starter template

@jongio
Copy link
Member

jongio commented Jul 16, 2024

@Menghua1 we can close this.

@Menghua1
Copy link
Member Author

@Menghua1 we can close this.

This issue cannot be closed yet, because not only is the endpoints missing, but also a connections is missing. I removed the unsupported endpoints and updated the description.

@Menghua1 Menghua1 changed the title [AVM Module Issue]: Machine Learning Module should add the creation of Microsoft.MachineLearningServices/workspaces/endpoint and Microsoft.MachineLearningServices/workspaces/connections [AVM Module Issue]: Machine Learning Module should add the creation of Microsoft.MachineLearningServices/workspaces/connections Jul 17, 2024
@Menghua1
Copy link
Member Author

@cecheta I've updated the issue to include only the connections.

@jtracey93
Copy link
Contributor

@cecheta are you able to provide an ETA on resolution for adding this to the module for @jongio, please?

Thanks

Jack

@cecheta
Copy link
Member

cecheta commented Jul 29, 2024

I will start looking at it now, however I am also working on the new avm/ptn/ai-platform/baseline module, and I am on leave for ~2 weeks from the start of August.

Hopefully this will be implemented before the end of August.

cecheta added a commit that referenced this issue Aug 14, 2024
…3027)

## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

Closes #2575. Adds connections to the module.

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.machine-learning-services.workspace](https://github.com/cecheta/bicep-registry-modules/actions/workflows/avm.res.machine-learning-services.workspace.yml/badge.svg?branch=ml-workspace-connections)](https://github.com/cecheta/bicep-registry-modules/actions/workflows/avm.res.machine-learning-services.workspace.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

7 participants