-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AVM Module Issue]: Machine Learning Module should add the creation of Microsoft.MachineLearningServices/workspaces/connections
#2575
Comments
@Menghua1, thanks for submitting this issue for the Important Please note, that this module is currently orphaned. The @Azure/avm-core-team-technical-bicep, will attempt to find an owner for it. In the meantime, the core team may assist with this issue. Thank you for your patience! |
Hey @Menghua1, thanks for the issue. |
Good news, this module just got a new owner! @cecheta, can you please look into this issue? Thanks! CC: @ross-p-smith as secondary owner |
Thanks for raising this, we'll look into this in due course |
Hi @Menghua1 , it looks like {
"status": "Failed",
"error": {
"code": "DeploymentFailed",
"target": "/subscriptions/***/resourceGroups/rg-dev/providers/Microsoft.Resources/deployments/main",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
"details": [
{
"code": "ValidationError",
"message": "Endpoint resources are no longer supported, and have been migrated to connections. Please delete this resource and re-create it as a connection.",
"details": []
}
]
}
} Would it be ok to update the issue to just include connections? |
@jongio Any ideas about above comments? Could we consider only including |
Please track down where this module is being use, who added it to infra/core, and then figure out a path forward. |
We did not find repo to use this module and @wbreza added this module to infra/core. During the test, it looks like |
Let's see what @wbreza says. |
|
@Menghua1 we can close this. |
This issue cannot be closed yet, because not only is the |
Microsoft.MachineLearningServices/workspaces/endpoint
and Microsoft.MachineLearningServices/workspaces/connections
Microsoft.MachineLearningServices/workspaces/connections
@cecheta I've updated the issue to include only the |
I will start looking at it now, however I am also working on the new Hopefully this will be implemented before the end of August. |
…3027) ## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> Closes #2575. Adds connections to the module. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.machine-learning-services.workspace](https://github.com/cecheta/bicep-registry-modules/actions/workflows/avm.res.machine-learning-services.workspace.yml/badge.svg?branch=ml-workspace-connections)](https://github.com/cecheta/bicep-registry-modules/actions/workflows/avm.res.machine-learning-services.workspace.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/machine-learning-services/workspace
(Optional) Module Version
No response
Description
Please add the creation of
Microsoft.MachineLearningServices/workspaces/connections
.For example (azd):
CC: @jongio
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: