Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: DiffBackupIntervalInHours Error when provisioning Hyperscale SQL server #2469

Closed
1 task done
avivansh opened this issue Jun 18, 2024 · 12 comments · Fixed by #3715
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@avivansh
Copy link

avivansh commented Jun 18, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/sql/server

(Optional) Module Version

0.4.0

Description

I am trying to deploy this module but facing this error

[{"code":"FeatureIsNotAvailableForServiceTier","message":"Updating property DiffBackupIntervalInHours is not available for Hyperscale service tier."}]}]}]}]}]}]}]}

module

param name string
param dbName string
param location string
param virtualNetwork string
param subnet string
param tags object = {}

module server 'br/public:avm/res/sql/server:0.4.0' = {
  name: 'serverDeployment'
  params: {
    // Required parameters
    name: name
    // Non-required parameters
    administrators: {
      azureADOnlyAuthentication: true
      login: '*******'
      principalType: 'Application'
      sid: '*****'
      tenantId: '******'
    }
    databases: [
      {
        backupLongTermRetentionPolicy: {
            monthlyRetention: 'PT0S'
        }
        backupShortTermRetentionPolicy: {
            retentionDays: 7
        }
        capacity: 0
        collation: 'SQL_Latin1_General_CP1_CI_AS'
        licenseType: 'LicenseIncluded'
        maxSizeBytes: 34359738368
        name: dbName
        skuName: 'HS_Gen5'
        skuTier: 'Hyperscale'
        skuCapacity: 4
      }
    ]
    location: location
    managedIdentities: {
      systemAssigned: true
    }
    restrictOutboundNetworkAccess: 'Disabled'
    securityAlertPolicies: [
      {
        emailAccountAdmins: true
        name: 'Default'
        state: 'Enabled'
      }
    ]
    tags: tags
    virtualNetworkRules: [
      {
        ignoreMissingVnetServiceEndpoint: true
        name: 'newVnetRule1'
        virtualNetworkSubnetId: resourceId('Microsoft.Network/virtualNetworks/subnets', virtualNetwork, subnet)
      }
    ]
  }
}

(Optional) Correlation Id

No response

@avivansh avivansh added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 18, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Jun 18, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jun 18, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jun 18, 2024
Copy link

@avivansh, thanks for submitting this issue for the avm/res/sql/server module!

Important

A member of the @Azure/avm-res-sql-server-module-owners-bicep or @Azure/avm-res-sql-server-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jun 24, 2024
@bryansan-msft bryansan-msft removed their assignment Jun 26, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label Jul 2, 2024
@AlexanderSehr AlexanderSehr added the Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time label Jul 2, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jul 11, 2024

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@AlexanderSehr AlexanderSehr removed the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jul 17, 2024
@peterbud peterbud self-assigned this Oct 16, 2024
@ahelal
Copy link
Member

ahelal commented Oct 18, 2024

I am having the same issue too, As far as I see no way to conditionally use backupShortTermRetentionPolicy

@peterbud peterbud added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Language: Bicep 💪 This is related to the Bicep IaC language and removed Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time labels Nov 2, 2024
@peterbud
Copy link
Contributor

peterbud commented Nov 2, 2024

I can confirm, if no diffBackupIntervalInHours is specified, it will get the default value of 24, and that won't work for Hyperscale tier, leading to the above mentioned error.

@peterbud peterbud added Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Nov 2, 2024
AlexanderSehr pushed a commit that referenced this issue Nov 7, 2024
)

There are no Hyperscale tests in the repo (if needed we can add), but I
have tested it with an ad-hoc test.

Fixes #2469

## Description

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.sql.server](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml/badge.svg)](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml)
|

pls note: Maintenance window is not available in my subscription, hence
WAF test is failing.

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

5 participants