Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Align NAT Gateway Public IP implementation with e.g. Bastion & Azure Firewall #2378

Closed
AlexanderSehr opened this issue Feb 14, 2023 · 4 comments · Fixed by #3341
Closed

[Feature Request]: Align NAT Gateway Public IP implementation with e.g. Bastion & Azure Firewall #2378

AlexanderSehr opened this issue Feb 14, 2023 · 4 comments · Fixed by #3341
Assignees
@fabmas
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Comments

@AlexanderSehr
Copy link
Contributor

Description

The implementation of the NAT Gateway Public IP differs a lot from the other resources which introduces quite some inconsistency.

This is partly rooted in the fact that the NAT Gateway can have multiple Public IPs & alternative multiple Public IP Prefixes.

We should anyways align the approach and, for example, allow the user to either specify an array of Public IPs, or provide the configuration to create multiple Public IPs (- the same for prefixes).
@rahalan
Copy link
Contributor

rahalan commented Feb 14, 2023

ref: Azure Bastion and Azure Firewall

@rahalan rahalan self-assigned this Aug 10, 2023
@AlexanderSehr AlexanderSehr transferred this issue from Azure/ResourceModules Jun 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 14, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@AlexanderSehr AlexanderSehr assigned fabmas and unassigned rahalan Jun 14, 2024
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: In Triage 🔍 Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 14, 2024
@AlexanderSehr
Copy link
Contributor Author

Hey @fabmas,
I just migrated this issue from CARML. Please take a look if it's still relevant and triage :)

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jun 19, 2024
@fabmas fabmas removed the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Sep 20, 2024
@fabmas fabmas mentioned this issue Sep 20, 2024
Merged
11 tasks
@fabmas
Copy link
Member

fabmas commented Sep 20, 2024

Hi @AlexanderSehr
The module appears to be updated with the correct Public IP implementation version. I have included a test case that demonstrates the method for utilizing an existing Public IP by referencing its resourceID. The PR for the update is #3341

fabmas added a commit that referenced this issue Sep 23, 2024
@fabmas
fix: module avm/res/network/nat-gateway (#3341)
73fc84f 
## Description

added a test case about the use of an existing Public IP address

Closes #2378


## Pipeline Reference


[![avm.res.network.nat-gateway](https://github.com/fabmas/bicep-registry-modules/actions/workflows/avm.res.network.nat-gateway.yml/badge.svg?branch=natgw)](https://github.com/fabmas/bicep-registry-modules/actions/workflows/avm.res.network.nat-gateway.yml)

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@github-project-automation github-project-automation bot moved this from To do to Done in Backlog Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabmas fabmas

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
AVM - Module Issues
Status: Done
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: module avm/res/network/nat-gateway fabmas/bicep-registry-modules
3 participants
@AlexanderSehr @fabmas @rahalan