Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: How to retrieve a Managed Environment static IP? #2197

Closed
1 task done
arnaud-tincelin opened this issue Jun 5, 2024 · 3 comments · Fixed by #2265
Closed
1 task done

[AVM Module Issue]: How to retrieve a Managed Environment static IP? #2197

arnaud-tincelin opened this issue Jun 5, 2024 · 3 comments · Fixed by #2265
Assignees
@hundredacres
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Comments

@arnaud-tincelin
Copy link
Contributor

arnaud-tincelin commented Jun 5, 2024 •
edited
Loading

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

I'm not sure

Module Name

avm/res/app/managed-environment

(Optional) Module Version

No response

Description

I am following the Azure documentation

If you don't plan to use a custom domain, create a private DNS zone that resolves the Container Apps environment's default domain to the static IP address of the Container Apps environment. You can use Azure Private DNS or your own DNS server. If you use Azure Private DNS, create a private DNS Zone named as the Container App environment’s default domain (<UNIQUE_IDENTIFIER>.<REGION_NAME>.azurecontainerapps.io), with an A record. The A record contains the name * and the static IP address of the Container Apps environment.

The module has an output defaultDomain but I cannot find an output using the properties.staticIp value?

(Optional) Correlation Id

No response
@arnaud-tincelin arnaud-tincelin added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 5, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter AVM Team Linter
Copy link

@arnaud-tincelin, thanks for submitting this issue for the avm/res/app/managed-environment module!

Important

A member of the @Azure/avm-res-app-managedenvironment-module-owners-bicep or @Azure/avm-res-app-managedenvironment-module-contributors-bicep team will review it soon!

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jun 5, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jun 5, 2024
@hundredacres hundredacres mentioned this issue Jun 7, 2024
Merged
11 tasks
@hundredacres
Copy link
Contributor

PR: #2265

@hundredacres hundredacres removed the Needs: Triage 🔍 Maintainers need to triage still label Jun 7, 2024
@eriqua eriqua added Needs: Module Owner 📣 This module needs an owner to develop or maintain it and removed Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Jun 7, 2024
AlexanderSehr pushed a commit that referenced this issue Jun 9, 2024
@hundredacres @matebarabas
@rahalan @JFolberth @eriqua
feat: avm/res/app/managed-environment Output staticIP of Managed En…
b095b06 
…vironment (#2265)

## Description
New output for staticIP of the Managed Environment

Fixes #2197 
Closes #2197 


## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.app.managed-environment](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.app.managed-environment.yml/badge.svg?branch=feat%2Fissue%2F2197)](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.app.managed-environment.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [X] Azure Verified Module updates:
- [X] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [X] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [X] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [X] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Máté Barabás <[email protected]>
Co-authored-by: Rainer Halanek <[email protected]>
Co-authored-by: JFolberth <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Jun 9, 2024
hundredacres added a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
@hundredacres @matebarabas
@rahalan @JFolberth @eriqua
feat: avm/res/app/managed-environment Output staticIP of Managed En…
4ef62bc 
…vironment (Azure#2265)

## Description
New output for staticIP of the Managed Environment

Fixes Azure#2197 
Closes Azure#2197 


## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.app.managed-environment](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.app.managed-environment.yml/badge.svg?branch=feat%2Fissue%2F2197)](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.app.managed-environment.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [X] Azure Verified Module updates:
- [X] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [X] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [X] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [X] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Máté Barabás <[email protected]>
Co-authored-by: Rainer Halanek <[email protected]>
Co-authored-by: JFolberth <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hundredacres hundredacres

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
AVM - Module Issues
Status: Done
Milestone
No milestone
3 participants
@hundredacres @arnaud-tincelin @eriqua