Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failed pipeline] avm.res.service-fabric.cluster #1726

Closed
avm-team-linter bot opened this issue Apr 22, 2024 · 23 comments · Fixed by #1951
Closed

[Failed pipeline] avm.res.service-fabric.cluster #1726

avm-team-linter bot opened this issue Apr 22, 2024 · 23 comments · Fixed by #1951
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@avm-team-linter
Copy link

Failed run: https://github.com/Azure/bicep-registry-modules/actions/runs/8775243759

@avm-team-linter avm-team-linter bot added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working labels Apr 22, 2024
Copy link
Author

Warning

This issue couldn't be assigend due to an internal error. @lsnoddy, please make sure this issue is assigned to you and please provide an initial response as soon as possible, in accordance with the AVM Support statement.

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Apr 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 22, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

@lsnoddy lsnoddy added the Class: Resource Module 📦 This is a resource module label May 16, 2024
@lsnoddy
Copy link
Member

lsnoddy commented May 16, 2024

Updating test cases to fix failed run.

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

Copy link
Author

lsnoddy added a commit that referenced this issue Jun 13, 2024
…e-fabric/cluster` (#1951)

## Description

Updated test cases to fix failed pipeline:

- Added certificate param to satisfy secure cluster requirement
- Removed redundant cert test case
- Cleaned up other certificate params in the test cases

Closes #1726 

## Pipeline Reference


| Pipeline |
| -------- |

[![avm.res.service-fabric.cluster](https://github.com/lsnoddy/bicep-registry-modules/actions/workflows/avm.res.service-fabric.cluster.yml/badge.svg?branch=users%2Flsnoddy%2Fservice-fabric-cluster)](https://github.com/lsnoddy/bicep-registry-modules/actions/workflows/avm.res.service-fabric.cluster.yml)
|          |


## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Erika Gressi <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Jun 13, 2024
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
…e-fabric/cluster` (Azure#1951)

## Description

Updated test cases to fix failed pipeline:

- Added certificate param to satisfy secure cluster requirement
- Removed redundant cert test case
- Cleaned up other certificate params in the test cases

Closes Azure#1726 

## Pipeline Reference


| Pipeline |
| -------- |

[![avm.res.service-fabric.cluster](https://github.com/lsnoddy/bicep-registry-modules/actions/workflows/avm.res.service-fabric.cluster.yml/badge.svg?branch=users%2Flsnoddy%2Fservice-fabric-cluster)](https://github.com/lsnoddy/bicep-registry-modules/actions/workflows/avm.res.service-fabric.cluster.yml)
|          |


## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
1 participant