-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WAF - Reliability Review] - avm/res/app-configuration/configuration-store
#1502
Comments
Note, this module is currently orphaned: Azure/Azure-Verified-Modules#731 |
Seems |
@JFolberth is actively working on fixing this issue through PR #1696 |
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
Note This message was posted as per ITA02BCP. |
…figuration/configuration-store` (#1696) ## Description - Added replicas - Update settings per pester results - ReadMes Update - Configured replicas for WAF alignment - Removed orphan Markdown Fixes #1502 Closes #1502 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.app-configuration.configuration-store](https://github.com/JFolberth/bicep-registry-modules/actions/workflows/avm.res.app-configuration.configuration-store.yml/badge.svg)](https://github.com/JFolberth/bicep-registry-modules/actions/workflows/avm.res.app-configuration.configuration-store.yml)| ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Erika Gressi <[email protected]>
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/app-configuration/configuration-store
(Optional) Module Name if not listed above
No response
(Optional) Module Version
No response
Description
Hello team,
The AVM core team are performing a review of all AVM modules to ensure they are aligned to the WAF reliability pillar by default, and in the future they will be checking against other WAF pillars also. This is a requirement we have before we can go
v1.0.0
for any AVM module.Links to AVM specs:
Links to WAF Reliability, APRL & Product Docs recommendations used for analysis:
Whilst reviewing this module the following issues have been found that are non-compliant with the AVM specs that need to be resolved in a new version release that can be seen in the PSRule for Azure run here: https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.app-configuration.configuration-store.yml#summary-23300173139
Please make these changes in a PR to the parameter defaults so a new minor version can be published.
Thanks
The AVM Core Team
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: