Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Automation account credentials #1443

Closed
1 task done
jwoernerasi opened this issue Mar 27, 2024 · 3 comments · Fixed by #2183
Closed
1 task done

[AVM Module Issue]: Automation account credentials #1443

jwoernerasi opened this issue Mar 27, 2024 · 3 comments · Fixed by #2183
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@jwoernerasi
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/automation/automation-account

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

It doesn't seem like adding credential resources to an Automation Account is supported by the AVM. I'm having an extremely difficult time determining how to combin usage of the AA AVM with a manual declaration of a credential resource. Wondering if it's even possible.

(Optional) Correlation Id

No response

@jwoernerasi jwoernerasi added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 27, 2024
@github-actions github-actions bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review Class: Resource Module 📦 This is a resource module labels Mar 27, 2024
Copy link
Contributor

@jwoernerasi, thanks for submitting this issue for the avm/res/automation/automation-account module!

A member of the @azure/avm-res-automation-automationaccount-module-owners-bicep or @azure/avm-res-automation-automationaccount-module-contributors-bicep team will review it soon!

@eriqua eriqua changed the title [AVM Module Issue]: Credentials [AVM Module Issue]: Automation account credentials Mar 27, 2024
@elanzel
Copy link
Contributor

elanzel commented Mar 28, 2024

Hi @jwoernerasi thank you for contacting us.
I confirm credentials is a feature not yet available for this module. We are adding this issue to the new features requests.
Thank you,
best regards

@elanzel elanzel removed Needs: Triage 🔍 Maintainers need to triage still Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Mar 28, 2024
@elanzel
Copy link
Contributor

elanzel commented May 31, 2024

Added feature in my fork. Testing before opening the PR

elanzel added a commit that referenced this issue Jun 7, 2024
## Description

Fixes #1443
## Pipeline Reference
| Pipeline |
| -------- |
|
[![avm.res.automation.automation-account](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml/badge.svg?branch=feature%2Faut_credentials)](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml)
|

## Type of Change

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
## Description

Fixes Azure#1443
## Pipeline Reference
| Pipeline |
| -------- |
|
[![avm.res.automation.automation-account](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml/badge.svg?branch=feature%2Faut_credentials)](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml)
|

## Type of Change

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants