Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Storage account changeFeedRetentionInDays minValue should be set to 1 to avoid Warning BCP329 #1385

Closed
1 task done
brazarb opened this issue Mar 22, 2024 · 3 comments · Fixed by #1987
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Comments

@brazarb
Copy link

brazarb commented Mar 22, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

I'm not sure

Module Name

avm/res/storage/storage-account

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

image

(Optional) Correlation Id

No response

@brazarb brazarb added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 22, 2024
@github-actions github-actions bot added the Class: Resource Module 📦 This is a resource module label Mar 22, 2024
Copy link
Contributor

@brazarb, thanks for submitting this issue for the avm/res/storage/storage-account module!

A member of the @azure/avm-res-storage-storageaccount-module-owners-bicep or @azure/avm-res-storage-storageaccount-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Note

This message was posted as per ITA01BCP.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Mar 27, 2024
@matebarabas
Copy link
Contributor

Hi @brazarb, thank you for submitting this issue! Please note that owner of this module (@fblix) is currently OOF until April 2nd. We've raised this issue to his attention internally and asked him to pick this up when he's back. Thank you for your patience!

@matebarabas matebarabas added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Triage 🔍 Maintainers need to triage still Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Mar 28, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues May 22, 2024
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
…- `avm/res/storage/storage-account` (Azure#1987)

## Description

ported changes from Azure#1508 following comment from core team and fblix

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

Fixes Azure#1508 
Closes Azure#1674
Closes Azure#1731 
Closes Azure#1385 
Closes Azure#1346 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.storage.storage-account](https://github.com/ChrisSidebotham/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml/badge.svg?branch=storage-fix)](https://github.com/ChrisSidebotham/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change (Azure#1508 is open but should be abandoned)
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment