Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: SQL Server module documentation inaccurate #1324

Closed
1 task done
teemukom opened this issue Mar 18, 2024 · 2 comments · Fixed by #3318
Closed
1 task done

[Feedback]: SQL Server module documentation inaccurate #1324

teemukom opened this issue Mar 18, 2024 · 2 comments · Fixed by #3318
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Question/Feedback 🙋 Further information is requested or just some feedback

Comments

@teemukom
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/sql/server

Usage examples 3 and 6 have a database parameter 'capacity' which should be skuCapacity as described in the https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/sql/server/database/main.bicep

@teemukom teemukom added Needs: Triage 🔍 Maintainers need to triage still Type: Question/Feedback 🙋 Further information is requested or just some feedback labels Mar 18, 2024
@matebarabas
Copy link
Contributor

@teemukom, thank you for opening this issue. I'll move it to the right repository and will assign it to the owner of this module.

@matebarabas matebarabas transferred this issue from Azure/Azure-Verified-Modules Mar 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in Bicep Mar 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Mar 18, 2024
@matebarabas
Copy link
Contributor

@bryansan-msft, can you please help @teemukom with this issue? Thank you!

@matebarabas matebarabas removed the Needs: Triage 🔍 Maintainers need to triage still label Mar 18, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Mar 18, 2024
@shenglol shenglol removed this from Bicep Mar 18, 2024
@bryansan-msft bryansan-msft removed their assignment Jun 26, 2024
eriqua added a commit that referenced this issue Sep 27, 2024
…s/sql/server` (#3318)

Fixes #1324

## Description



## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

Co-authored-by: Erika Gressi <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Question/Feedback 🙋 Further information is requested or just some feedback
Projects
3 participants