[Bug Report]: AKS examples documented configuring NoSchedule taint on wrong node pools #1064
Assignees
Labels
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: Bug 🐛
Something isn't working
Type: Documentation 📄
Improvements or additions to documentation
Comments
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
microsoft-github-policy-service
bot
added
Status: Response Overdue 🚩
|
Hi @jonasssa, I will take look and will update the docs as soon as possible. |
|
Tagging the AVM Core Team (@Azure/avm-core-team) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. |
|
This issue requires the AVM Core Team's (@Azure/avm-core-team) immediate attention as it hasn't been responded to within 6 business days. |
microsoft-github-policy-service
bot
added
the
Needs: Immediate Attention ‼️
AlexanderSehr
removed
Needs: Triage 🔍
ChrisSidebotham
added
the
Needs: Attention 👋
JPEasier
added
Type: Documentation 📄
PixelRobots
added a commit
to PixelRobots/bicep-registry-modules
that referenced
this issue
Apr 19, 2024
Signed-off-by: PixelRobots <[email protected]>
11 tasks
ilhaan
pushed a commit
that referenced
this issue
Apr 19, 2024
#1715) ## Description Closes #1064 <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/PixelRobots/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [X] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> Signed-off-by: PixelRobots <[email protected]>
donk-msft
pushed a commit
to donk-msft/bicep-registry-modules
that referenced
this issue
Apr 29, 2024
](https://github.com/PixelRobots/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml){kind=link}
…uster` (Azure#1715) ## Description Closes Azure#1064 <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#123 Fixes Azure#456 Closes Azure#123 Closes Azure#456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/PixelRobots/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [X] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> Signed-off-by: PixelRobots <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Module path
avm/res/container-service/managed-cluster/README.md
Bicep version
0.1.1
Describe the bug
Looks like the examples in the documentation are setting the following taint on the user agent pool, while it should be on the system node pool if im not mistaken.
L90-L92 should be on L73-L75
L115-L117 should be removed
L667-L669 should be on L650-L652
L690-L692 should be removed
etc... (same goes for all 4 examples)
To reproduce
Open the readme here and look at the examples: avm/res/container-service/managed-cluster/README.md
Code snippet
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: