Skip to content

Commit

Permalink
feat: Remove unused PSRule custom rule for Azure Storage replication (#…
Browse files Browse the repository at this point in the history
…2712)

The PSRule custom rule for Azure Storage replication has been removed as
it is no longer needed as it was updated in
[Upstream](Azure/PSRule.Rules.Azure#2828).

## Description

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.load-test-service.load-test](https://github.com/sebassem/bicep-registry-modules/actions/workflows/avm.res.load-test-service.load-test.yml/badge.svg?branch=avm-psrule-revert-storage.replication-rule)](https://github.com/sebassem/bicep-registry-modules/actions/workflows/avm.res.load-test-service.load-test.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [X] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [X] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

Co-authored-by: Felipe Binotto <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
  • Loading branch information
3 people authored Jul 16, 2024
1 parent 3740074 commit 9ce1720
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.

This file was deleted.

3 changes: 1 addition & 2 deletions avm/utilities/pipelines/staticValidation/psrule/ps-rule.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,10 @@ configuration:

rule:
# Enable custom rules that don't exist in the baseline
includeLocal: true
includeLocal: false
exclude:
# Ignore the following rules for all resources
- Azure.KeyVault.PurgeProtect
- Azure.VM.UseHybridUseBenefit
- Azure.Storage.UseReplication
- Azure.AppConfig.PurgeProtect
- Azure.APIM.MultiRegion # Team agreed this is too expensive for most use cases and is safe to ignore.

0 comments on commit 9ce1720

Please sign in to comment.