Adjust description for role assign param

Azure · Jan 19, 2024 · 6179391 · 6179391
1 parent 96817eb
commit 6179391
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 28 deletions.
diff --git a/avm/res/app/container-app/README.md b/avm/res/app/container-app/README.md
@@ -854,7 +854,7 @@ Array of role assignments to create.
 | Parameter | Type | Description |
 | :-- | :-- | :-- |
 | [`principalId`](#parameter-roleassignmentsprincipalid) | string | The principal ID of the principal (user/group/identity) to assign the role to. |
-| [`roleDefinitionIdOrName`](#parameter-roleassignmentsroledefinitionidorname) | string | The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID in the following format: '/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11'. |
+| [`roleDefinitionIdOrName`](#parameter-roleassignmentsroledefinitionidorname) | string | The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID. |
 
 **Optional parameters**
 
@@ -875,7 +875,7 @@ The principal ID of the principal (user/group/identity) to assign the role to.
 
 ### Parameter: `roleAssignments.roleDefinitionIdOrName`
 
-The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID in the following format: '/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11'.
+The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID.
 
 - Required: Yes
 - Type: string

diff --git a/avm/res/app/container-app/main.bicep b/avm/res/app/container-app/main.bicep
@@ -195,29 +195,29 @@ resource containerApp 'Microsoft.App/containerApps@2023-05-01' = {
 }
 
 resource containerApp_diagnosticSettings 'Microsoft.Insights/diagnosticSettings@2021-05-01-preview' = [for (diagnosticSetting, index) in (diagnosticSettings ?? []): {
- name: diagnosticSetting.?name ?? '${name}-diagnosticSettings'
- properties: {
-  storageAccountId: diagnosticSetting.?storageAccountResourceId
-  workspaceId: diagnosticSetting.?workspaceResourceId
-  eventHubAuthorizationRuleId: diagnosticSetting.?eventHubAuthorizationRuleResourceId
-  eventHubName: diagnosticSetting.?eventHubName
-  metrics: diagnosticSetting.?metricCategories ?? [
-    {
-      category: 'AllMetrics'
-      timeGrain: null
-      enabled: true
-    }
-  ]
-  logs: diagnosticSetting.?logCategoriesAndGroups ?? [
-    {
-      categoryGroup: 'AllLogs'
-      enabled: true
-    }
-  ]
-  marketplacePartnerId: diagnosticSetting.?marketplacePartnerResourceId
-  logAnalyticsDestinationType: diagnosticSetting.?logAnalyticsDestinationType
-}
-scope: containerApp
+  name: diagnosticSetting.?name ?? '${name}-diagnosticSettings'
+  properties: {
+    storageAccountId: diagnosticSetting.?storageAccountResourceId
+    workspaceId: diagnosticSetting.?workspaceResourceId
+    eventHubAuthorizationRuleId: diagnosticSetting.?eventHubAuthorizationRuleResourceId
+    eventHubName: diagnosticSetting.?eventHubName
+    metrics: diagnosticSetting.?metricCategories ?? [
+      {
+        category: 'AllMetrics'
+        timeGrain: null
+        enabled: true
+      }
+    ]
+    logs: diagnosticSetting.?logCategoriesAndGroups ?? [
+      {
+        categoryGroup: 'AllLogs'
+        enabled: true
+      }
+    ]
+    marketplacePartnerId: diagnosticSetting.?marketplacePartnerResourceId
+    logAnalyticsDestinationType: diagnosticSetting.?logAnalyticsDestinationType
+  }
+  scope: containerApp
 }]
 
 resource containerApp_lock 'Microsoft.Authorization/locks@2020-05-01' = if (!empty(lock ?? {}) && lock.?kind != 'None') {
@@ -317,7 +317,7 @@ type lockType = {
 }?
 
 type roleAssignmentType = {
-  @description('Required. The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID in the following format: \'/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11\'.')
+  @description('Required. The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID.')
   roleDefinitionIdOrName: string
 
   @description('Required. The principal ID of the principal (user/group/identity) to assign the role to.')

diff --git a/avm/res/app/container-app/main.json b/avm/res/app/container-app/main.json
@@ -6,7 +6,7 @@
     "_generator": {
       "name": "bicep",
       "version": "0.21.1.54444",
-      "templateHash": "12570382725911183040"
+      "templateHash": "3392999924402888168"
     },
     "name": "Container Apps",
     "description": "This module deploys a Container App.",
@@ -175,7 +175,7 @@
           "roleDefinitionIdOrName": {
             "type": "string",
             "metadata": {
-              "description": "Required. The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID in the following format: '/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11'."
+              "description": "Required. The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID."
             }
           },
           "principalId": {