Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Add workaround to circumvent azure-cli's lack of support for ID token refresh #3328

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

kdestin
Copy link
Member

@kdestin kdestin commented Aug 1, 2024

Description

This pull request adds a workaround for an issue where some workflows would fail with the following error when requesting an access-token

ClientAuthenticationError: ERROR: AADSTS700024: Client assertion is not within its valid time range. Current time: 2024-07-31T13:29:11.3373885Z, assertion valid from 2024-07-31T12:49:53.0000000Z, expiry time of assertion 2024-07-31T12:54:53.0000000Z. Review the documentation at https://learn.microsoft.com/entra/identity-platform/certificate-credentials . Trace ID: 0ff4799d-034f-4a47-a51c-73b333b61a00 Correlation ID: fd15cb9d-734e-4a7c-9d96-0e2069f9c11b Timestamp: 2024-07-31 13:29:11Z
Interactive authentication is needed. Please run:
az login

Bugfix for #3253, root cause is likely Azure/login#372

Background

Workflows in this repository were migrated to federated authentication using OIDC in #3253.

We've since run into a bug with several workflows similar to the bug described in Azure/login#372: an authentication issue occurs with that authenticate with OIDC after running for sufficiently long.

A comment in the thread includes a collection of workarounds as a stopgap until the root cause is fixed in azure-cli: Azure/login#372 (comment)

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@kdestin kdestin enabled auto-merge (squash) August 5, 2024 18:50
@kdestin
Copy link
Member Author

kdestin commented Aug 12, 2024

@microsoft-github-policy-service rerun

@kdestin kdestin merged commit ce99aa8 into main Aug 12, 2024
277 of 304 checks passed
@kdestin kdestin deleted the kdestin/eagerly-request-oidc-token branch August 12, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants