Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add azure-identity java example #585

Merged
merged 1 commit into from
Oct 7, 2022
Merged

feat: add azure-identity java example #585

merged 1 commit into from
Oct 7, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 6, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

part of #187

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase requested a review from sozercan October 6, 2022 23:22
sozercan
sozercan approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase enabled auto-merge (squash) October 6, 2022 23:27
@aramase aramase merged commit 885c9d1 into Azure:main Oct 7, 2022
@aramase aramase deleted the azidentity-java branch October 7, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramase @sozercan