Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating AppInsights nugets #2213

Merged
merged 2 commits into from
Jun 17, 2019
Merged

updating AppInsights nugets #2213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c47a04
updating AppInsights nugets
brettsam May 30, 2019
f61fa93
AddApplicationInsights -> AddApplicationInsightsWebJobs
brettsam Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...obs.Logging.ApplicationInsights/Extensions/ApplicationInsightsLoggingBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static class ApplicationInsightsLoggingBuilderExtensions
public static ILoggingBuilder AddApplicationInsights(
this ILoggingBuilder builder)
{
return builder.AddApplicationInsights(null);
return AddApplicationInsights(builder, null);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an ambiguous reference... I'm assuming the new AspNetCore package includes the AddApplicationInsights() extension. Wasn't sure if it was worth updating to that or not...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to update to our new loggerprovider. But please consider marking this method as obsoltete, and provide a new one with AppApplicationInsightsWebJob

}

/// <summary>
Expand Down
14 changes: 7 additions & 7 deletions ...soft.Azure.WebJobs.Logging.ApplicationInsights/WebJobs.Logging.ApplicationInsights.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.6.1" />
<PackageReference Include="Microsoft.ApplicationInsights.PerfCounterCollector" Version="2.9.1" />
<PackageReference Include="Microsoft.ApplicationInsights.SnapshotCollector" Version="1.3.0" />
<PackageReference Include="Microsoft.ApplicationInsights.WindowsServer" Version="2.9.1" />
<PackageReference Include="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" Version="2.9.1" />
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.7.0" />
<PackageReference Include="Microsoft.ApplicationInsights.PerfCounterCollector" Version="2.10.0" />
<PackageReference Include="Microsoft.ApplicationInsights.SnapshotCollector" Version="1.3.4" />
<PackageReference Include="Microsoft.ApplicationInsights.WindowsServer" Version="2.10.0" />
<PackageReference Include="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" Version="2.10.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="2.1.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.1.0" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.9.1" />
<PackageReference Include="Microsoft.ApplicationInsights.DependencyCollector" Version="2.9.1" />
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.10.0" />
<PackageReference Include="Microsoft.ApplicationInsights.DependencyCollector" Version="2.10.0" />
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.1.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.1.0" />
<PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
Expand Down