Remove old dependencies by adding net6 target framework #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bApiCompatShim code in net6
Havunen
commented
Aug 21, 2023
|
|
||
| namespace Microsoft.Azure.WebJobs.Extensions.Http.Shim | ||
| { | ||
| public class HttpRequestMessageFeature : IHttpRequestMessageFeature |
There was a problem hiding this comment.
this code is copied here from the Microsoft.AspNetCore.Mvc.WebApiCompatShim package:
ref: https://github.com/aspnet/Mvc/blob/b18526cdc8d8c868e8d7f9c6c8484064215e1002/src/Microsoft.AspNetCore.Mvc.WebApiCompatShim/HttpRequestMessage/HttpRequestMessageFeature.cs
in case somebody somehow manages to call this code path
|
It seems the tests are not passing in dev branch either... |
…ts on both .NET 6 and .NET 8
Havunen
changed the title
…net8 target framework due to missing SDKs in CI
Havunen
changed the title
Havunen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old dependencies by adding net6 target framework and ignore WebApiCompatShim code in net6