Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom names for values in data binding #787

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

MO2k4
Copy link

@MO2k4 MO2k4 commented Jul 15, 2022

Currently it is not possible to use different names for binding than the property names. To be more flexible, i added a check if DataMemberAttribute is set and use this name instead of the property name

public class TestPocoWithDataMember
{
    [DataMember(Name = "custom_value")]
    public string CustomValue { get; set; }

    public string Location { get; set; }
}

This would allow the developer to bind the data against query parameter like custom_value.

@net-foundation-cla
Copy link

net-foundation-cla bot commented Jul 15, 2022

CLA assistant check
All CLA requirements met.

@MO2k4
Copy link
Author

MO2k4 commented Aug 23, 2022

@mathewc @fabiocav Sorry for contacting you directly, but i've seen that you closed some prs in the last weeks.

Could you please take a look at my pr? If you are not the correct persons mentioned, could you please forward my pr for review? Is there anything i could do or improve in my pr to get this merged?

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants