-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rename): azure-nvme-utils -> azure-vm-utils #40
Conversation
To support expansion of scope for future utilities and udev rules outside of NVMe support, rename azure-nvme-utils to azure-vm-utils. Signed-off-by: Chris Patterson <[email protected]>
What kind of things are you going to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Consolidating rules that are packaged in walinuxagent, vendor baked (SCSI disk, networking, etc.), and perhaps cloud-init. Initially the scope will be the new disk rules, but the longer-term goal is to have a clear home for any essential udev rules & relevant utilities that aren't upstreamable and decouple ties to the guest agent. For example, on RHEL 9:
Ubuntu 22.04:
SUSE:
• /usr/lib/udev/rules.d/66-azure-ephemeral.rules: cloud-init We want to handle any transition carefully to avoid conflicts so there will be a published roadmap/plan in place before that happens. Given the limited of proliferation of azure-nvme-utils, doing a rename now will reduce churn going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given this a try on Gentoo now. Looks good.
To support expansion of scope for future utilities and udev rules outside of NVMe support, rename azure-nvme-utils to azure-vm-utils.