Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rename): azure-nvme-utils -> azure-vm-utils #40

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cjp256
Copy link
Collaborator

@cjp256 cjp256 commented Aug 29, 2024

To support expansion of scope for future utilities and udev rules outside of NVMe support, rename azure-nvme-utils to azure-vm-utils.

To support expansion of scope for future utilities and udev
rules outside of NVMe support, rename azure-nvme-utils to
azure-vm-utils.

Signed-off-by: Chris Patterson <[email protected]>
@chewi
Copy link
Collaborator

chewi commented Aug 29, 2024

What kind of things are you going to add?

Copy link
Collaborator

@anhvoms anhvoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@cjp256
Copy link
Collaborator Author

cjp256 commented Aug 29, 2024

What kind of things are you going to add?

Consolidating rules that are packaged in walinuxagent, vendor baked (SCSI disk, networking, etc.), and perhaps cloud-init. Initially the scope will be the new disk rules, but the longer-term goal is to have a clear home for any essential udev rules & relevant utilities that aren't upstreamable and decouple ties to the guest agent.

For example, on RHEL 9:

for f in $(find /etc/NetworkManager /etc/udev/ /lib/udev/ | grep azure | sort); do echo "$f: $(rpm -qf $f)"; done
• /etc/NetworkManager/conf.d/99-azure-unmanaged-devices.conf: file is not owned by any package (installed by image customization by RHEL team)
• /etc/NetworkManager/dispatcher.d/cloud-init-azure-hook: cloud-init
• /etc/udev/rules.d/68-azure-sriov-nm-unmanaged.rules: file is not owned by any package (installed by image customization by RHEL team)
• /lib/udev/rules.d/66-azure-ephemeral.rules: cloud-init-23.1.1-12.el9_3.noarch
• /lib/udev/rules.d/66-azure-storage.rules: WALinuxAgent-udev-2.7.0.6-9.el9_2.1.noarch
• /lib/udev/rules.d/99-azure-product-uuid.rules: WALinuxAgent-udev-2.7.0.6-9.el9_2.1.noarch

Ubuntu 22.04:

$ for f in $(find /etc/udev/ /lib/udev/ | grep azure | sort); do echo "$f: $(dpkg -S $f)"; done
• /etc/udev/rules.d/66-azure-storage.rules: walinuxagent
• /etc/udev/rules.d/99-azure-product-uuid.rules: walinuxagent
• /lib/udev/rules.d/66-azure-ephemeral.rules: cloud-init
• /lib/udev/rules.d/66-azure-storage.rules: walinuxagent
• /lib/udev/rules.d/67-azure-console.rules: walinuxagent
• /lib/udev/rules.d/68-azure-nm-unmanaged.rules: walinuxagent

SUSE:

$for f in $(find /etc/NetworkManager /etc/udev/ /usr/lib/udev/ | grep azure | sort); do echo "$f: $(rpm -qf $f)"; done

• /usr/lib/udev/rules.d/66-azure-ephemeral.rules: cloud-init
• /usr/lib/udev/rules.d/66-azure-storage.rules: python-azure-agent
• /usr/lib/udev/rules.d/99-azure-product-uuid.rules: python-azure-agent

We want to handle any transition carefully to avoid conflicts so there will be a published roadmap/plan in place before that happens. Given the limited of proliferation of azure-nvme-utils, doing a rename now will reduce churn going forward.

Copy link
Collaborator

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given this a try on Gentoo now. Looks good.

@cjp256 cjp256 merged commit 0f55fd7 into Azure:main Sep 5, 2024
7 checks passed
@cjp256 cjp256 deleted the rename branch September 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants