Adding Find-AzureVmKnownIssuesWindows.ps1 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CraigWiand
reviewed
Sep 25, 2018
Find-AzureVmKnownIssuesWindows.ps1
Outdated
|
|
||
| # | ||
| # RDP settigns | ||
|
|
Find-AzureVmKnownIssuesWindows.ps1
Outdated
| $Current = (Get-ItemProperty HKLM:\SYSTEM\Select -Name Current).Current | ||
| if ($null -eq $Current) | ||
| { | ||
| $Current = 1 # dafault |
Find-AzureVmKnownIssuesWindows.ps1
Outdated
| Write-Host ("`nWARN | Deny RDP Connections`n RDP is set to deny connections, current value of 'fDenyTSConnections' is '{0}'`n Run the following commands to fix this problem: (copy & paste line by line)`n >`n `$reg='HKLM:\System\ControlSet00$Current\Control\Terminal Server'`n Set-ItemProperty -Path `$reg -Name 'fDenyTSConnections' -Value 0`n" -f $RDPSettings.fDenyTSConnections) -ForegroundColor Yellow | ||
| } | ||
|
|
||
| # if PortNumber is not 3380 then RDP is not using the default port |
Find-AzureVmKnownIssuesWindows.ps1
Outdated
| Write-Host ("`nWARN | RDP is listening on a specific NIC `n Remore Desktop is listening on NIC '{0}', by default RDP listen on all NICs`n Run the following commands to fix this problem: (copy & paste line by line)`n >`n `$reg='HKLM:\SYSTEM\ControlSet00$Current\Control\Terminal Server\WinStations\RDP-Tcp'`n Set-ItemProperty -Path `$reg -Name 'LanAdapter' -Value 0`n Restart-Service TermService -Force`n" -f $RDPSettings.LanAdapter) -ForegroundColor Yellow | ||
| } | ||
|
|
||
| # RDP settigns |
There was a problem hiding this comment.
typo. Did you actually mean to have the same heading again here? I see you do that consistently below. Perhaps there is a open/close section syntax?
Find-AzureVmKnownIssuesWindows.ps1
Outdated
| elseif ($nics.Count -eq 1) | ||
| { | ||
| # netconnectionstatus = 2 > Connected | ||
| if ($nics[0].netconnectionstatus -ne 2) |
There was a problem hiding this comment.
Can you use an enum above so you could do something like [NicStatus]::Connected? Likely would make it easier to read
Find-AzureVmKnownIssuesWindows.ps1
Outdated
| # if PortNumber is not 3380 then RDP is not using the default port | ||
| if ($RDPSettings.PortNumber -ne 3389) | ||
| { | ||
| Write-Host ("`nWARN | RDP is not using default Port`n Remore Desktop is set use '{0}' Port, the default RDP port is '3389'`n Run the following commands to fix this problem: (copy & paste line by line)`n >`n `$reg='HKLM:\SYSTEM\ControlSet00$Current\Control\Terminal Server\WinStations\RDP-Tcp'`n Set-ItemProperty -Path `$reg -Name 'PortNumber' -Value 3389`n Restart-Service TermService -Force`n" -f $RDPSettings.PortNumber) -ForegroundColor Yellow |
There was a problem hiding this comment.
port instead of capital Port a couple times
CraigWiand
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Find-AzureVmKnownIssuesWindows.ps1 which will help troubleshoot unable to RDP issues for Windows VMs when using Serial Console on Azure Portal